2022-11-13 02:33:11

by Ian Cowan

Subject: [PATCH] staging: media: sunxi: cedrus: make vb2_ops struct definition const

This cleans up a checkstyle warning where the vb2_ops struct definitions
should be const.

Signed-off-by: Ian Cowan <[email protected]>
---
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
index 66714609b577..0664b4a4fdac 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
@@ -548,7 +548,7 @@ static void cedrus_buf_request_complete(struct vb2_buffer *vb)
v4l2_ctrl_request_complete(vb->req_obj.req, &ctx->hdl);
}

-static struct vb2_ops cedrus_qops = {
+static const struct vb2_ops cedrus_qops = {
.queue_setup = cedrus_queue_setup,
.buf_prepare = cedrus_buf_prepare,
.buf_queue = cedrus_buf_queue,
--
2.38.1

2022-11-13 18:09:42

by Samuel Holland

Subject: Re: [PATCH] staging: media: sunxi: cedrus: make vb2_ops struct definition const

On 11/12/22 19:47, Ian Cowan wrote:
> This cleans up a checkstyle warning where the vb2_ops struct definitions
> should be const.
>
> Signed-off-by: Ian Cowan <[email protected]>
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Samuel Holland <[email protected]>