2022-11-14 09:44:25

by Miquel Raynal

Subject: [PATCH v4 3/5] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout

From: Michael Walle <[email protected]>

Add a schema for the NVMEM layout on Kontron's sl28 boards.

Signed-off-by: Michael Walle <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
---
.../nvmem/layouts/kontron,sl28-vpd.yaml | 62 +++++++++++++++++++
.../bindings/nvmem/layouts/nvmem-layout.yaml | 3 +
2 files changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml

diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
new file mode 100644
index 000000000000..fef795e79c36
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVMEM layout of the Kontron SMARC-sAL28 vital product data
+
+maintainers:
+ - Michael Walle <[email protected]>
+
+description:
+ The vital product data (VPD) of the sl28 boards contains a serial
+ number and a base MAC address. The actual MAC addresses for the
+ on-board ethernet devices are derived from this base MAC address by
+ adding an offset.
+
+select: false
+
+properties:
+ compatible:
+ const: kontron,sl28-vpd
+
+ serial-number:
+ type: object
+ description: The board's serial number
+
+ base-mac-address:
+ type: object
+ description:
+ Base MAC address for all on-module network interfaces. The first
+ argument of the phandle will be treated as an offset.
+
+ properties:
+ "#nvmem-cell-cells":
+ const: 1
+
+ additionalProperties: false
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ otp-1 {
+ compatible = "user-otp";
+
+ nvmem-layout {
+ compatible = "kontron,sl28-vpd";
+
+ serial_number: serial-number {
+ };
+
+ base_mac_address: base-mac-address {
+ #nvmem-cell-cells = <1>;
+ };
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
index ecc7c37cbc1f..f64ea2fa362d 100644
--- a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
+++ b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
@@ -17,6 +17,9 @@ description: |
define and might require dynamic reading of the NVMEM device in order to
perform their parsing. The nvmem-layout container is here to describe these.

+oneOf:
+ - $ref: kontron,sl28-vpd.yaml
+
properties:
compatible: true

--
2.34.1

2022-11-16 21:04:11

by Rob Herring (Arm)

Subject: Re: [PATCH v4 3/5] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout

On Mon, Nov 14, 2022 at 09:56:57AM +0100, Miquel Raynal wrote:
> From: Michael Walle <[email protected]>
>
> Add a schema for the NVMEM layout on Kontron's sl28 boards.
>
> Signed-off-by: Michael Walle <[email protected]>
> Signed-off-by: Miquel Raynal <[email protected]>
> ---
> .../nvmem/layouts/kontron,sl28-vpd.yaml | 62 +++++++++++++++++++
> .../bindings/nvmem/layouts/nvmem-layout.yaml | 3 +
> 2 files changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
>
> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
> new file mode 100644
> index 000000000000..fef795e79c36
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVMEM layout of the Kontron SMARC-sAL28 vital product data
> +
> +maintainers:
> + - Michael Walle <[email protected]>
> +
> +description:
> + The vital product data (VPD) of the sl28 boards contains a serial
> + number and a base MAC address. The actual MAC addresses for the
> + on-board ethernet devices are derived from this base MAC address by
> + adding an offset.
> +
> +select: false
> +
> +properties:
> + compatible:
> + const: kontron,sl28-vpd
> +
> + serial-number:
> + type: object

additionalProperties: false

With that,

Reviewed-by: Rob Herring <[email protected]>

> + description: The board's serial number
> +
> + base-mac-address:
> + type: object
> + description:
> + Base MAC address for all on-module network interfaces. The first
> + argument of the phandle will be treated as an offset.
> +
> + properties:
> + "#nvmem-cell-cells":
> + const: 1
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + otp-1 {
> + compatible = "user-otp";
> +
> + nvmem-layout {
> + compatible = "kontron,sl28-vpd";
> +
> + serial_number: serial-number {
> + };
> +
> + base_mac_address: base-mac-address {
> + #nvmem-cell-cells = <1>;
> + };
> + };
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
> index ecc7c37cbc1f..f64ea2fa362d 100644
> --- a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml
> @@ -17,6 +17,9 @@ description: |
> define and might require dynamic reading of the NVMEM device in order to
> perform their parsing. The nvmem-layout container is here to describe these.
>
> +oneOf:
> + - $ref: kontron,sl28-vpd.yaml
> +
> properties:
> compatible: true
>
> --
> 2.34.1
>
>

2022-11-16 21:45:29

by Miquel Raynal

Subject: Re: [PATCH v4 3/5] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout

Hi Rob, Srinivas,

[email protected] wrote on Wed, 16 Nov 2022 14:52:03 -0600:

> On Mon, Nov 14, 2022 at 09:56:57AM +0100, Miquel Raynal wrote:
> > From: Michael Walle <[email protected]>
> >
> > Add a schema for the NVMEM layout on Kontron's sl28 boards.
> >
> > Signed-off-by: Michael Walle <[email protected]>
> > Signed-off-by: Miquel Raynal <[email protected]>
> > ---
> > .../nvmem/layouts/kontron,sl28-vpd.yaml | 62 +++++++++++++++++++
> > .../bindings/nvmem/layouts/nvmem-layout.yaml | 3 +
> > 2 files changed, 65 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
> > new file mode 100644
> > index 000000000000..fef795e79c36
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
> > @@ -0,0 +1,62 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVMEM layout of the Kontron SMARC-sAL28 vital product data
> > +
> > +maintainers:
> > + - Michael Walle <[email protected]>
> > +
> > +description:
> > + The vital product data (VPD) of the sl28 boards contains a serial
> > + number and a base MAC address. The actual MAC addresses for the
> > + on-board ethernet devices are derived from this base MAC address by
> > + adding an offset.
> > +
> > +select: false
> > +
> > +properties:
> > + compatible:
> > + const: kontron,sl28-vpd
> > +
> > + serial-number:
> > + type: object
>
> additionalProperties: false

Right, I missed that one.

> With that,
>
> Reviewed-by: Rob Herring <[email protected]>

Thanks for all the reviews!

Srinivas, would you add the above property while applying or do you
prefer me to send a v5?

Thanks,
Miquèl

2022-11-16 23:07:56

by Srinivas Kandagatla

Subject: Re: [PATCH v4 3/5] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout

On 16/11/2022 21:28, Miquel Raynal wrote:
> Hi Rob, Srinivas,
>
> [email protected] wrote on Wed, 16 Nov 2022 14:52:03 -0600:
>
>> On Mon, Nov 14, 2022 at 09:56:57AM +0100, Miquel Raynal wrote:
>>> From: Michael Walle <[email protected]>
>>>
>>> Add a schema for the NVMEM layout on Kontron's sl28 boards.
>>>
>>> Signed-off-by: Michael Walle <[email protected]>
>>> Signed-off-by: Miquel Raynal <[email protected]>
>>> ---
>>> .../nvmem/layouts/kontron,sl28-vpd.yaml | 62 +++++++++++++++++++
>>> .../bindings/nvmem/layouts/nvmem-layout.yaml | 3 +
>>> 2 files changed, 65 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
>>> new file mode 100644
>>> index 000000000000..fef795e79c36
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
>>> @@ -0,0 +1,62 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: NVMEM layout of the Kontron SMARC-sAL28 vital product data
>>> +
>>> +maintainers:
>>> + - Michael Walle <[email protected]>
>>> +
>>> +description:
>>> + The vital product data (VPD) of the sl28 boards contains a serial
>>> + number and a base MAC address. The actual MAC addresses for the
>>> + on-board ethernet devices are derived from this base MAC address by
>>> + adding an offset.
>>> +
>>> +select: false
>>> +
>>> +properties:
>>> + compatible:
>>> + const: kontron,sl28-vpd
>>> +
>>> + serial-number:
>>> + type: object
>>
>> additionalProperties: false
>
> Right, I missed that one.
>
>> With that,
>>
>> Reviewed-by: Rob Herring <[email protected]>
>
> Thanks for all the reviews!
>
> Srinivas, would you add the above property while applying or do you
> prefer me to send a v5?

Applied the series after adding the property.

--srini
>
> Thanks,
> Miquèl