2022-11-15 04:15:50

by Bo Liu

Subject: [PATCH] aio: replace IS_ERR() with IS_ERR_VALUE()

Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE()
instead.

Signed-off-by: Bo Liu <[email protected]>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/aio.c b/fs/aio.c
index 5b2ff20ad322..978bbfb8dcac 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -556,7 +556,7 @@ static int aio_setup_ring(struct kioctx *ctx, unsigned int nr_events)
PROT_READ | PROT_WRITE,
MAP_SHARED, 0, &unused, NULL);
mmap_write_unlock(mm);
- if (IS_ERR((void *)ctx->mmap_base)) {
+ if (IS_ERR_VALUE(ctx->mmap_base)) {
ctx->mmap_size = 0;
aio_free_ring(ctx);
return -ENOMEM;
--
2.27.0

2022-11-15 19:37:44

by Chaitanya Kulkarni

Subject: Re: [PATCH] aio: replace IS_ERR() with IS_ERR_VALUE()

On 11/14/22 19:16, Bo Liu wrote:
> Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE()
> instead.
>
> Signed-off-by: Bo Liu <[email protected]>
> ---
>

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck