2022-11-16 02:10:52

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] migrate: stop using 0 as NULL pointer

mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index 15dc56a3da7a..e50b3c42e6ad 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page,
return -ENOMEM;
dst = page_folio(newpage);

- dst->private = 0;
+ dst->private = NULL;
rc = __unmap_and_move(src, dst, force, mode);
if (rc == MIGRATEPAGE_SUCCESS)
set_page_owner_migrate_reason(&dst->page, reason);
--
2.20.1.7.g153144c



2022-11-17 11:58:42

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH -next] migrate: stop using 0 as NULL pointer

On 16.11.22 02:23, Yang Li wrote:
> mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> mm/migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 15dc56a3da7a..e50b3c42e6ad 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page,
> return -ENOMEM;
> dst = page_folio(newpage);
>
> - dst->private = 0;
> + dst->private = NULL;
> rc = __unmap_and_move(src, dst, force, mode);
> if (rc == MIGRATEPAGE_SUCCESS)
> set_page_owner_migrate_reason(&dst->page, reason);

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb