2022-11-15 22:14:36

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the arm64 tree

---

Hi all,

After merging the arm64 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/perf/arm_cspmu/arm_cspmu.c: In function 'arm_cspmu_get_cpus':
drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit declaration of function 'get_acpi_id_for_cpu' [-Werror=implicit-function-declaration]
1114 | get_acpi_id_for_cpu(cpu)) {
| ^~~~~~~~~~~~~~~~~~~

Caused by commit

e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU driver")

I have used the arm64 tree from next-20221115 for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-11-16 00:09:58

by Besar Wicaksono

[permalink] [raw]

Subject: RE: linux-next: build failure after merge of the arm64 tree

---

> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: Tuesday, November 15, 2022 4:04 PM
> To: Catalin Marinas <[email protected]>; Will Deacon
> <[email protected]>
> Cc: Besar Wicaksono <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; Linux Next Mailing List <linux-
> [email protected]>
> Subject: linux-next: build failure after merge of the arm64 tree
>
> Hi all,
>
> After merging the arm64 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/perf/arm_cspmu/arm_cspmu.c: In function 'arm_cspmu_get_cpus':
> drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit declaration of
> function 'get_acpi_id_for_cpu' [-Werror=implicit-function-declaration]
> 1114 | get_acpi_id_for_cpu(cpu)) {
> | ^~~~~~~~~~~~~~~~~~~
>

+CC Suzuki for awareness.

This function is used for searching CPU with matching ACPI Processor ID in PPTT.
I will check if adding PPTT dependency to arm_cspmu would resolve this issue.

Regards,
Besar

> Caused by commit
>
> e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU
> driver")
>
> I have used the arm64 tree from next-20221115 for today.
>
> --
> Cheers,
> Stephen Rothwell

2022-11-16 11:50:39

by Suzuki K Poulose

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the arm64 tree

---

On 15/11/2022 23:52, Besar Wicaksono wrote:
>
>
>> -----Original Message-----
>> From: Stephen Rothwell <[email protected]>
>> Sent: Tuesday, November 15, 2022 4:04 PM
>> To: Catalin Marinas <[email protected]>; Will Deacon
>> <[email protected]>
>> Cc: Besar Wicaksono <[email protected]>; Linux Kernel Mailing List
>> <[email protected]>; Linux Next Mailing List <linux-
>> [email protected]>
>> Subject: linux-next: build failure after merge of the arm64 tree
>>
>> Hi all,
>>
>> After merging the arm64 tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/perf/arm_cspmu/arm_cspmu.c: In function 'arm_cspmu_get_cpus':
>> drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit declaration of
>> function 'get_acpi_id_for_cpu' [-Werror=implicit-function-declaration]
>> 1114 | get_acpi_id_for_cpu(cpu)) {
>> | ^~~~~~~~~~~~~~~~~~~
>>
>
> +CC Suzuki for awareness.
>
> This function is used for searching CPU with matching ACPI Processor ID in PPTT.
> I will check if adding PPTT dependency to arm_cspmu would resolve this issue.

Please make this dependent on ARM64. That should resolve the failure.
As such the helper is available with ARM64 && ACPI.

Suzuki

>
> Regards,
> Besar
>
>> Caused by commit
>>
>> e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU
>> driver")
>>
>> I have used the arm64 tree from next-20221115 for today.
>>
>> --
>> Cheers,
>> Stephen Rothwell