From: Jianglei Nie <[email protected]>
lpfcdiag_sli3_loop_post_rxbufs() allocates a memory chunk from "rxbuffer"
with diag_cmd_data_alloc(). The "rxbuffer" should be freed when gets some
error. But when the function gets some error and jump to
"err_post_rxbufs_exit",The "rxbuffer" is not released, which will lead to
a memory leak.
We should free the "rxbuffer" with diag_cmd_data_free() in
"err_post_rxbufs_exit" when the "rxbuffer" is not NULL.
Signed-off-by: Jianglei Nie <[email protected]>
Signed-off-by: Jianglei Nie <[email protected]>
---
drivers/scsi/lpfc/lpfc_bsg.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index 852b025e2fec..2693def758b7 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -2989,8 +2989,11 @@ static int lpfcdiag_sli3_loop_post_rxbufs(struct lpfc_hba *phba, uint16_t rxxri,
err_post_rxbufs_exit:
if (rxbmp) {
- if (rxbmp->virt)
+ if (rxbmp->virt) {
+ if (rxbuffer != NULL)
+ diag_cmd_data_free(phba, rxbuffer);
lpfc_mbuf_free(phba, rxbmp->virt, rxbmp->phys);
+ }
kfree(rxbmp);
}
--
2.25.1