2022-11-18 11:05:59

by Denis Arefev

Subject: [PATCH] iommu: amd: Added value check

Аdded a return value check for the function
mmu_notifier_register.

Return value of a function 'mmu_notifier_register'
called at iommu_v2.c:642 is not checked,
but it is usually checked for this function

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Denis Arefev <[email protected]>
---
drivers/iommu/amd/iommu_v2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/amd/iommu_v2.c b/drivers/iommu/amd/iommu_v2.c
index 5ecc0bc608ec..88134f34589f 100644
--- a/drivers/iommu/amd/iommu_v2.c
+++ b/drivers/iommu/amd/iommu_v2.c
@@ -639,7 +639,9 @@ int amd_iommu_bind_pasid(struct pci_dev *pdev, u32 pasid,
if (pasid_state->mm == NULL)
goto out_free;

- mmu_notifier_register(&pasid_state->mn, mm);
+ ret = mmu_notifier_register(&pasid_state->mn, mm);
+ if (ret)
+ goto out_free;

ret = set_pasid_state(dev_state, pasid_state, pasid);
if (ret)
--
2.25.1

2022-11-19 10:15:09

by Joerg Roedel

Subject: Re: [PATCH] iommu: amd: Added value check

On Fri, Nov 18, 2022 at 01:42:52PM +0300, Denis Arefev wrote:
> Аdded a return value check for the function
> mmu_notifier_register.
>
> Return value of a function 'mmu_notifier_register'
> called at iommu_v2.c:642 is not checked,
> but it is usually checked for this function
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <[email protected]>
> ---
> drivers/iommu/amd/iommu_v2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.