2022-11-18 15:03:38

by Gabriel L. Somlo

Subject: [PATCH v5 04/14] serial: liteuart: don't set unused port fields

Remove regshift and iobase port fields, since they are unused
by the driver.

Signed-off-by: Gabriel Somlo <[email protected]>
---
drivers/tty/serial/liteuart.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index 989a4f8d5bd4..c6eb7eba5af8 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -263,9 +263,7 @@ static int liteuart_probe(struct platform_device *pdev)
port->iotype = UPIO_MEM;
port->flags = UPF_BOOT_AUTOCONF;
port->ops = &liteuart_ops;
- port->regshift = 2;
port->fifosize = 16;
- port->iobase = 1;
port->type = PORT_UNKNOWN;
port->line = dev_id;
spin_lock_init(&port->lock);
--
2.38.1

2022-11-21 10:10:39

by Geert Uytterhoeven

Subject: Re: [PATCH v5 04/14] serial: liteuart: don't set unused port fields

On Fri, Nov 18, 2022 at 3:55 PM Gabriel Somlo <[email protected]> wrote:
> Remove regshift and iobase port fields, since they are unused
> by the driver.
>
> Signed-off-by: Gabriel Somlo <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds