2022-11-18 22:50:26

by Uwe Kleine-König

Subject: [PATCH 021/606] drm/bridge: it66121: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/ite-it66121.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 4f6f1deba28c..7476cfbf9585 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -1512,8 +1512,7 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
return PTR_ERR_OR_ZERO(ctx->audio.pdev);
}

-static int it66121_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int it66121_probe(struct i2c_client *client)
{
u32 revision_id, vendor_ids[2] = { 0 }, device_ids[2] = { 0 };
struct device_node *ep;
@@ -1649,7 +1648,7 @@ static struct i2c_driver it66121_driver = {
.name = "it66121",
.of_match_table = it66121_dt_match,
},
- .probe = it66121_probe,
+ .probe_new = it66121_probe,
.remove = it66121_remove,
.id_table = it66121_id,
};
--
2.38.1

2022-11-19 17:56:19

by Laurent Pinchart

Subject: Re: [PATCH 021/606] drm/bridge: it66121: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:35:55PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 4f6f1deba28c..7476cfbf9585 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1512,8 +1512,7 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
> return PTR_ERR_OR_ZERO(ctx->audio.pdev);
> }
>
> -static int it66121_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int it66121_probe(struct i2c_client *client)
> {
> u32 revision_id, vendor_ids[2] = { 0 }, device_ids[2] = { 0 };
> struct device_node *ep;
> @@ -1649,7 +1648,7 @@ static struct i2c_driver it66121_driver = {
> .name = "it66121",
> .of_match_table = it66121_dt_match,
> },
> - .probe = it66121_probe,
> + .probe_new = it66121_probe,
> .remove = it66121_remove,
> .id_table = it66121_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart