2022-11-18 23:20:24

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 022/606] drm/bridge: lt8912b: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index a98efef0ba0e..c5fff9b41dfc 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -685,8 +685,7 @@ static int lt8912_put_dt(struct lt8912 *lt)
return 0;
}

-static int lt8912_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lt8912_probe(struct i2c_client *client)
{
static struct lt8912 *lt;
int ret = 0;
@@ -758,7 +757,7 @@ static struct i2c_driver lt8912_i2c_driver = {
.name = "lt8912",
.of_match_table = lt8912_dt_match,
},
- .probe = lt8912_probe,
+ .probe_new = lt8912_probe,
.remove = lt8912_remove,
.id_table = lt8912_id,
};
--
2.38.1



2022-11-19 18:17:18

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 022/606] drm/bridge: lt8912b: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:35:56PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> index a98efef0ba0e..c5fff9b41dfc 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -685,8 +685,7 @@ static int lt8912_put_dt(struct lt8912 *lt)
> return 0;
> }
>
> -static int lt8912_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int lt8912_probe(struct i2c_client *client)
> {
> static struct lt8912 *lt;
> int ret = 0;
> @@ -758,7 +757,7 @@ static struct i2c_driver lt8912_i2c_driver = {
> .name = "lt8912",
> .of_match_table = lt8912_dt_match,
> },
> - .probe = lt8912_probe,
> + .probe_new = lt8912_probe,
> .remove = lt8912_remove,
> .id_table = lt8912_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart