2022-11-19 00:39:27

by Uwe Kleine-König

Subject: [PATCH 348/606] media: i2c/ml86v7667: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/media/i2c/ml86v7667.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/ml86v7667.c b/drivers/media/i2c/ml86v7667.c
index 49ec59b0ca43..dbd2f0bd3651 100644
--- a/drivers/media/i2c/ml86v7667.c
+++ b/drivers/media/i2c/ml86v7667.c
@@ -359,8 +359,7 @@ static int ml86v7667_init(struct ml86v7667_priv *priv)
return ret;
}

-static int ml86v7667_probe(struct i2c_client *client,
- const struct i2c_device_id *did)
+static int ml86v7667_probe(struct i2c_client *client)
{
struct ml86v7667_priv *priv;
int ret;
@@ -434,7 +433,7 @@ static struct i2c_driver ml86v7667_i2c_driver = {
.driver = {
.name = DRV_NAME,
},
- .probe = ml86v7667_probe,
+ .probe_new = ml86v7667_probe,
.remove = ml86v7667_remove,
.id_table = ml86v7667_id,
};
--
2.38.1

2022-11-19 18:08:45

by Laurent Pinchart

Subject: Re: [PATCH 348/606] media: i2c/ml86v7667: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/ml86v7667.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ml86v7667.c b/drivers/media/i2c/ml86v7667.c
> index 49ec59b0ca43..dbd2f0bd3651 100644
> --- a/drivers/media/i2c/ml86v7667.c
> +++ b/drivers/media/i2c/ml86v7667.c
> @@ -359,8 +359,7 @@ static int ml86v7667_init(struct ml86v7667_priv *priv)
> return ret;
> }
>
> -static int ml86v7667_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int ml86v7667_probe(struct i2c_client *client)
> {
> struct ml86v7667_priv *priv;
> int ret;
> @@ -434,7 +433,7 @@ static struct i2c_driver ml86v7667_i2c_driver = {
> .driver = {
> .name = DRV_NAME,
> },
> - .probe = ml86v7667_probe,
> + .probe_new = ml86v7667_probe,
> .remove = ml86v7667_remove,
> .id_table = ml86v7667_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart