2022-11-19 01:16:01

by Uwe Kleine-König

Subject: [PATCH 350/606] media: i2c/mt9m032: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/media/i2c/mt9m032.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c
index 76b8c9c08c82..958cfdd73d57 100644
--- a/drivers/media/i2c/mt9m032.c
+++ b/drivers/media/i2c/mt9m032.c
@@ -701,8 +701,7 @@ static const struct v4l2_subdev_ops mt9m032_ops = {
* Driver initialization and probing
*/

-static int mt9m032_probe(struct i2c_client *client,
- const struct i2c_device_id *devid)
+static int mt9m032_probe(struct i2c_client *client)
{
struct mt9m032_platform_data *pdata = client->dev.platform_data;
struct i2c_adapter *adapter = client->adapter;
@@ -880,7 +879,7 @@ static struct i2c_driver mt9m032_i2c_driver = {
.driver = {
.name = MT9M032_NAME,
},
- .probe = mt9m032_probe,
+ .probe_new = mt9m032_probe,
.remove = mt9m032_remove,
.id_table = mt9m032_id_table,
};
--
2.38.1

2022-11-19 18:26:07

by Laurent Pinchart

Subject: Re: [PATCH 350/606] media: i2c/mt9m032: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:41:24PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/mt9m032.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c
> index 76b8c9c08c82..958cfdd73d57 100644
> --- a/drivers/media/i2c/mt9m032.c
> +++ b/drivers/media/i2c/mt9m032.c
> @@ -701,8 +701,7 @@ static const struct v4l2_subdev_ops mt9m032_ops = {
> * Driver initialization and probing
> */
>
> -static int mt9m032_probe(struct i2c_client *client,
> - const struct i2c_device_id *devid)
> +static int mt9m032_probe(struct i2c_client *client)
> {
> struct mt9m032_platform_data *pdata = client->dev.platform_data;
> struct i2c_adapter *adapter = client->adapter;
> @@ -880,7 +879,7 @@ static struct i2c_driver mt9m032_i2c_driver = {
> .driver = {
> .name = MT9M032_NAME,
> },
> - .probe = mt9m032_probe,
> + .probe_new = mt9m032_probe,
> .remove = mt9m032_remove,
> .id_table = mt9m032_id_table,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart