2022-11-19 01:13:52

by Uwe Kleine-König

Subject: [PATCH 351/606] media: i2c/mt9p031: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/media/i2c/mt9p031.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index 45f7b5e52bc3..ecee8a58d930 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -1097,9 +1097,9 @@ mt9p031_get_pdata(struct i2c_client *client)
return pdata;
}

-static int mt9p031_probe(struct i2c_client *client,
- const struct i2c_device_id *did)
+static int mt9p031_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *did = i2c_client_get_device_id(client);
struct mt9p031_platform_data *pdata = mt9p031_get_pdata(client);
struct i2c_adapter *adapter = client->adapter;
struct mt9p031 *mt9p031;
@@ -1243,7 +1243,7 @@ static struct i2c_driver mt9p031_i2c_driver = {
.of_match_table = of_match_ptr(mt9p031_of_match),
.name = "mt9p031",
},
- .probe = mt9p031_probe,
+ .probe_new = mt9p031_probe,
.remove = mt9p031_remove,
.id_table = mt9p031_id,
};
--
2.38.1

2022-11-19 18:18:22

by Laurent Pinchart

Subject: Re: [PATCH 351/606] media: i2c/mt9p031: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:41:25PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/mt9p031.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index 45f7b5e52bc3..ecee8a58d930 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -1097,9 +1097,9 @@ mt9p031_get_pdata(struct i2c_client *client)
> return pdata;
> }
>
> -static int mt9p031_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int mt9p031_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *did = i2c_client_get_device_id(client);
> struct mt9p031_platform_data *pdata = mt9p031_get_pdata(client);
> struct i2c_adapter *adapter = client->adapter;
> struct mt9p031 *mt9p031;
> @@ -1243,7 +1243,7 @@ static struct i2c_driver mt9p031_i2c_driver = {
> .of_match_table = of_match_ptr(mt9p031_of_match),
> .name = "mt9p031",
> },
> - .probe = mt9p031_probe,
> + .probe_new = mt9p031_probe,
> .remove = mt9p031_remove,
> .id_table = mt9p031_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart