From: Uwe Kleine-König <[email protected]>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/rtc/rtc-isl1208.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 73cc6aaf9b8b..fca9cc440296 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -799,6 +799,7 @@ static int isl1208_setup_irq(struct i2c_client *client, int irq)
static int
isl1208_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
int rc = 0;
struct isl1208_state *isl1208;
int evdet_irq = -1;
--
2.38.1
On 18/11/2022 23:44:55+0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
This is already done later on in the function, please check the rtc
patches as I took your previous series.
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
> drivers/rtc/rtc-isl1208.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
> index 73cc6aaf9b8b..fca9cc440296 100644
> --- a/drivers/rtc/rtc-isl1208.c
> +++ b/drivers/rtc/rtc-isl1208.c
> @@ -799,6 +799,7 @@ static int isl1208_setup_irq(struct i2c_client *client, int irq)
> static int
> isl1208_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> int rc = 0;
> struct isl1208_state *isl1208;
> int evdet_irq = -1;
> --
> 2.38.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hello Alexandre,
On Sun, Nov 20, 2022 at 12:58:44AM +0100, Alexandre Belloni wrote:
> On 18/11/2022 23:44:55+0100, Uwe Kleine-K?nig wrote:
> > From: Uwe Kleine-K?nig <[email protected]>
> >
> > .probe_new() doesn't get the i2c_device_id * parameter, so determine
> > that explicitly in the probe function.
> >
>
> This is already done later on in the function, please check the rtc
> patches as I took your previous series.
huh, sorry I missed that. In this previous series you refused to take
the ds1307 patch. The one from this series is better.
I dropped the other rtc patches from my queue.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |