2022-11-19 00:32:25

by Uwe Kleine-König

Subject: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/video/backlight/adp8860_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index b0fe02273e87..a479aab90f78 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -648,9 +648,9 @@ static const struct attribute_group adp8860_bl_attr_group = {
.attrs = adp8860_bl_attributes,
};

-static int adp8860_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int adp8860_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct backlight_device *bl;
struct adp8860_bl *data;
struct adp8860_backlight_platform_data *pdata =
@@ -803,7 +803,7 @@ static struct i2c_driver adp8860_driver = {
.name = KBUILD_MODNAME,
.pm = &adp8860_i2c_pm_ops,
},
- .probe = adp8860_probe,
+ .probe_new = adp8860_probe,
.remove = adp8860_remove,
.id_table = adp8860_id,
};
--
2.38.1

2022-11-21 10:03:12

by Hennerich, Michael

Subject: RE: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

> -----Original Message-----
> From: Uwe Kleine-König <[email protected]>
> Sent: Freitag, 18. November 2022 23:45
> To: Angel Iglesias <[email protected]>; Lee Jones
> <[email protected]>; Grant Likely <[email protected]>; Wolfram
> Sang <[email protected]>; Hennerich, Michael
> <[email protected]>; Lee Jones <[email protected]>; Daniel
> Thompson <[email protected]>; Jingoo Han
> <[email protected]>; Helge Deller <[email protected]>
> Cc: [email protected]; [email protected]; Uwe Kleine-König
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()
>
>
> From: Uwe Kleine-König <[email protected]>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine that
> explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

> ---
> drivers/video/backlight/adp8860_bl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c
> b/drivers/video/backlight/adp8860_bl.c
> index b0fe02273e87..a479aab90f78 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -648,9 +648,9 @@ static const struct attribute_group
> adp8860_bl_attr_group = {
> .attrs = adp8860_bl_attributes,
> };
>
> -static int adp8860_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int adp8860_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct backlight_device *bl;
> struct adp8860_bl *data;
> struct adp8860_backlight_platform_data *pdata = @@ -803,7 +803,7
> @@ static struct i2c_driver adp8860_driver = {
> .name = KBUILD_MODNAME,
> .pm = &adp8860_i2c_pm_ops,
> },
> - .probe = adp8860_probe,
> + .probe_new = adp8860_probe,
> .remove = adp8860_remove,
> .id_table = adp8860_id,
> };
> --
> 2.38.1

2022-11-21 10:28:21

by Daniel Thompson

Subject: Re: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:45:19PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.