2022-11-19 00:40:37

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 590/606] backlight: lm3639: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/video/backlight/lm3639_bl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 6580911671a3..a836628ce06e 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -296,8 +296,7 @@ static const struct regmap_config lm3639_regmap = {
.max_register = REG_MAX,
};

-static int lm3639_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3639_probe(struct i2c_client *client)
{
int ret;
struct lm3639_chip_data *pchip;
@@ -412,7 +411,7 @@ static struct i2c_driver lm3639_i2c_driver = {
.driver = {
.name = LM3639_NAME,
},
- .probe = lm3639_probe,
+ .probe_new = lm3639_probe,
.remove = lm3639_remove,
.id_table = lm3639_id,
};
--
2.38.1



2022-11-21 12:21:20

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH 590/606] backlight: lm3639: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:45:24PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.