2022-09-09 08:52:40

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH] arm64: dts: imx8mq: fix dtschema warning for imx7-csi

According to dtschema for the csi bridge, compatible is an enum and
only one must be used. Fixing this removes the following warning:

compatible: 'oneOf' conditional failed, one must be fixed

Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index e9f0cdd10ab62..a348169c40f15 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1184,7 +1184,7 @@ csi1_mipi_ep: endpoint {
};

csi1: csi@30a90000 {
- compatible = "fsl,imx8mq-csi", "fsl,imx7-csi";
+ compatible = "fsl,imx8mq-csi";
reg = <0x30a90000 0x10000>;
interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MQ_CLK_CSI1_ROOT>;
@@ -1236,7 +1236,7 @@ csi2_mipi_ep: endpoint {
};

csi2: csi@30b80000 {
- compatible = "fsl,imx8mq-csi", "fsl,imx7-csi";
+ compatible = "fsl,imx8mq-csi";
reg = <0x30b80000 0x10000>;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MQ_CLK_CSI2_ROOT>;
--
2.30.2


2022-11-16 10:13:48

by Martin Kepplinger

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mq: fix dtschema warning for imx7-csi

Am Freitag, dem 09.09.2022 um 10:39 +0200 schrieb Martin Kepplinger:
> According to dtschema for the csi bridge, compatible is an enum and
> only one must be used. Fixing this removes the following warning:
>
> compatible: 'oneOf' conditional failed, one must be fixed
>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index e9f0cdd10ab62..a348169c40f15 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1184,7 +1184,7 @@ csi1_mipi_ep: endpoint {
>                         };
>  
>                         csi1: csi@30a90000 {
> -                               compatible = "fsl,imx8mq-csi",
> "fsl,imx7-csi";
> +                               compatible = "fsl,imx8mq-csi";
>                                 reg = <0x30a90000 0x10000>;
>                                 interrupts = <GIC_SPI 42
> IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX8MQ_CLK_CSI1_ROOT>;
> @@ -1236,7 +1236,7 @@ csi2_mipi_ep: endpoint {
>                         };
>  
>                         csi2: csi@30b80000 {
> -                               compatible = "fsl,imx8mq-csi",
> "fsl,imx7-csi";
> +                               compatible = "fsl,imx8mq-csi";
>                                 reg = <0x30b80000 0x10000>;
>                                 interrupts = <GIC_SPI 43
> IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX8MQ_CLK_CSI2_ROOT>;

hi Shawn and all interested in DTC warnings,

does this look ok to you? it should still apply. thank you,

martin



2022-11-19 02:11:39

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mq: fix dtschema warning for imx7-csi

On Fri, Sep 09, 2022 at 10:39:40AM +0200, Martin Kepplinger wrote:
> According to dtschema for the csi bridge, compatible is an enum and
> only one must be used. Fixing this removes the following warning:
>
> compatible: 'oneOf' conditional failed, one must be fixed
>
> Signed-off-by: Martin Kepplinger <[email protected]>

Applied, thanks!