2022-11-15 18:16:48

by Philippe Schenker

Subject: [PATCH v2] ARM: dts: colibri-imx6ull: Enable dual-role switching

From: Philippe Schenker <[email protected]>

The Colibri standard provides a GPIO called USBC_DET to switch from
USB Host to USB Device and back. Make use of this GPIO by adding it
with usb-connector framework.

Signed-off-by: Philippe Schenker <[email protected]>

---

Changes in v2:
- Switched from extcon-usb-gpio to usb-connector-gpio

arch/arm/boot/dts/imx6ull-colibri.dtsi | 29 ++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
index a4429ba1f2ae..336ab2e0534c 100644
--- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
@@ -24,6 +24,28 @@ backlight: backlight {
status = "disabled";
};

+ connector {
+ compatible = "gpio-usb-b-connector", "usb-b-connector";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_snvs_usbc_det>;
+ id-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>; /* SODIMM 137 / USBC_DET */
+ label = "USBC";
+ self-powered;
+ type = "micro";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ usb_dr_connector: endpoint {
+ remote-endpoint = <&usb1_drd_sw>;
+ };
+ };
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -280,6 +302,13 @@ &usbotg1 {
srp-disable;
hnp-disable;
adp-disable;
+ usb-role-switch;
+
+ port {
+ usb1_drd_sw: endpoint {
+ remote-endpoint = <&usb_dr_connector>;
+ };
+ };
};

/* Colibri USBH */
--
2.38.1

2022-11-19 01:54:47

by Shawn Guo

Subject: Re: [PATCH v2] ARM: dts: colibri-imx6ull: Enable dual-role switching

On Tue, Nov 15, 2022 at 07:05:54PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <[email protected]>
>
> The Colibri standard provides a GPIO called USBC_DET to switch from
> USB Host to USB Device and back. Make use of this GPIO by adding it
> with usb-connector framework.
>
> Signed-off-by: Philippe Schenker <[email protected]>

Applied, thanks!