2022-11-19 01:12:32

by Uwe Kleine-König

Subject: [PATCH 353/606] media: i2c/mt9t112: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/media/i2c/mt9t112.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c
index ad564095d0cf..a82f056787b8 100644
--- a/drivers/media/i2c/mt9t112.c
+++ b/drivers/media/i2c/mt9t112.c
@@ -1060,8 +1060,7 @@ static int mt9t112_camera_probe(struct i2c_client *client)
return ret;
}

-static int mt9t112_probe(struct i2c_client *client,
- const struct i2c_device_id *did)
+static int mt9t112_probe(struct i2c_client *client)
{
struct mt9t112_priv *priv;
int ret;
@@ -1120,7 +1119,7 @@ static struct i2c_driver mt9t112_i2c_driver = {
.driver = {
.name = "mt9t112",
},
- .probe = mt9t112_probe,
+ .probe_new = mt9t112_probe,
.remove = mt9t112_remove,
.id_table = mt9t112_id,
};
--
2.38.1

2022-11-21 13:20:54

by jacopo mondi

Subject: Re: [PATCH 353/606] media: i2c/mt9t112: Convert to i2c's .probe_new()

Hi Uwe

On Fri, Nov 18, 2022 at 11:41:27PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---

Acked-by: Jacopo Mondi <[email protected]>


> drivers/media/i2c/mt9t112.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c
> index ad564095d0cf..a82f056787b8 100644
> --- a/drivers/media/i2c/mt9t112.c
> +++ b/drivers/media/i2c/mt9t112.c
> @@ -1060,8 +1060,7 @@ static int mt9t112_camera_probe(struct i2c_client *client)
> return ret;
> }
>
> -static int mt9t112_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int mt9t112_probe(struct i2c_client *client)
> {
> struct mt9t112_priv *priv;
> int ret;
> @@ -1120,7 +1119,7 @@ static struct i2c_driver mt9t112_i2c_driver = {
> .driver = {
> .name = "mt9t112",
> },
> - .probe = mt9t112_probe,
> + .probe_new = mt9t112_probe,
> .remove = mt9t112_remove,
> .id_table = mt9t112_id,
> };
> --
> 2.38.1
>