2022-11-19 00:37:37

by Uwe Kleine-König

Subject: [PATCH 362/606] media: i2c/rj54n1cb0c: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/media/i2c/rj54n1cb0c.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
index 1c3502f34cd3..9db5473daba0 100644
--- a/drivers/media/i2c/rj54n1cb0c.c
+++ b/drivers/media/i2c/rj54n1cb0c.c
@@ -1297,8 +1297,7 @@ static int rj54n1_video_probe(struct i2c_client *client,
return ret;
}

-static int rj54n1_probe(struct i2c_client *client,
- const struct i2c_device_id *did)
+static int rj54n1_probe(struct i2c_client *client)
{
struct rj54n1 *rj54n1;
struct i2c_adapter *adapter = client->adapter;
@@ -1422,7 +1421,7 @@ static struct i2c_driver rj54n1_i2c_driver = {
.driver = {
.name = "rj54n1cb0c",
},
- .probe = rj54n1_probe,
+ .probe_new = rj54n1_probe,
.remove = rj54n1_remove,
.id_table = rj54n1_id,
};
--
2.38.1

2022-11-21 13:25:08

by jacopo mondi

Subject: Re: [PATCH 362/606] media: i2c/rj54n1cb0c: Convert to i2c's .probe_new()

Hi Uwe

On Fri, Nov 18, 2022 at 11:41:36PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Jacopo Mondi <[email protected]>

Thanks
j

> ---
> drivers/media/i2c/rj54n1cb0c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
> index 1c3502f34cd3..9db5473daba0 100644
> --- a/drivers/media/i2c/rj54n1cb0c.c
> +++ b/drivers/media/i2c/rj54n1cb0c.c
> @@ -1297,8 +1297,7 @@ static int rj54n1_video_probe(struct i2c_client *client,
> return ret;
> }
>
> -static int rj54n1_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int rj54n1_probe(struct i2c_client *client)
> {
> struct rj54n1 *rj54n1;
> struct i2c_adapter *adapter = client->adapter;
> @@ -1422,7 +1421,7 @@ static struct i2c_driver rj54n1_i2c_driver = {
> .driver = {
> .name = "rj54n1cb0c",
> },
> - .probe = rj54n1_probe,
> + .probe_new = rj54n1_probe,
> .remove = rj54n1_remove,
> .id_table = rj54n1_id,
> };
> --
> 2.38.1
>