2022-11-18 17:30:37

by Dmitry Torokhov

Subject: [PATCH] MIPS: DTS: CI20: fix reset line polarity of the ethernet controller

The reset line is called PWRST#, annotated as "active low" in the
binding documentation, and is driven low and then high by the driver to
reset the chip. However in device tree for CI20 board it was incorrectly
marked as "active high". Fix it.

Because (as far as I know) the ci20.dts is always built in the kernel I
elected not to also add a quirk to gpiolib to force the polarity there.

Fixes: db49ca38579d ("net: davicom: dm9000: switch to using gpiod API")
Reported-by: Paul Cercueil <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
index 37c46720c719..f38c39572a9e 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -438,7 +438,7 @@ dm9000@6 {
ingenic,nemc-tAW = <50>;
ingenic,nemc-tSTRV = <100>;

- reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>;
vcc-supply = <&eth0_power>;

interrupt-parent = <&gpe>;
--
2.38.1.584.g0f3c55d4c2-goog


--
Dmitry

2022-11-21 17:10:36

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: DTS: CI20: fix reset line polarity of the ethernet controller

On Fri, Nov 18, 2022 at 08:43:47AM -0800, Dmitry Torokhov wrote:
> The reset line is called PWRST#, annotated as "active low" in the
> binding documentation, and is driven low and then high by the driver to
> reset the chip. However in device tree for CI20 board it was incorrectly
> marked as "active high". Fix it.
>
> Because (as far as I know) the ci20.dts is always built in the kernel I
> elected not to also add a quirk to gpiolib to force the polarity there.
>
> Fixes: db49ca38579d ("net: davicom: dm9000: switch to using gpiod API")
> Reported-by: Paul Cercueil <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index 37c46720c719..f38c39572a9e 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -438,7 +438,7 @@ dm9000@6 {
> ingenic,nemc-tAW = <50>;
> ingenic,nemc-tSTRV = <100>;
>
> - reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>;
> vcc-supply = <&eth0_power>;
>
> interrupt-parent = <&gpe>;
> --
> 2.38.1.584.g0f3c55d4c2-goog

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]