This is a short series to link a registered USB PD object to its associated
partner device. This is helpful for userspace services (the ChromeOS Type-C
daemon, for example), to identify which Type-C peripheral a PD object belongs to,
when a uevent for the PD object arrives.
The first patch adds a helper to the Type-C class code to access the device struct
for a partner. The second patch uses that helper to set the parent for the USB PD object
in the port driver code.
There was an earlier patch[1] to solve this issue, but it's been jettisoned (on advice from
GregKH) in favor of the current approach.
[1] https://lore.kernel.org/linux-usb/[email protected]/T/#m7521020f64d878313d7dd79903ec0e9421aa8737
Series submission suggestions (if the approach is OK):
- Patch 1 goes throug the USB tree and Patch 2 goes in the next release cycle
through the chrome-platform tree.
- Patch 1 and 2 both go through the USB tree.
Prashant Malani (2):
usb: typec: Add helper to get partner device struct
platform/chrome: cros_ec_typec: Set parent of partner PD object
drivers/platform/chrome/cros_ec_typec.c | 2 +-
drivers/usb/typec/class.c | 13 +++++++++++++
include/linux/usb/typec.h | 2 ++
3 files changed, 16 insertions(+), 1 deletion(-)
--
2.38.1.584.g0f3c55d4c2-goog
In order to tell what Type-C device a PD object belongs to, its parent
needs to be set. Set the parent appropriately for PD objects which are
created for connected Type-C partners.
Cc: Benson Leung <[email protected]>
Cc: Heikki Krogerus <[email protected]>
Signed-off-by: Prashant Malani <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 2a7ff14dc37e..a1cc23b86f3c 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -968,7 +968,7 @@ static void cros_typec_register_partner_pdos(struct cros_typec_data *typec,
if (!resp->source_cap_count && !resp->sink_cap_count)
return;
- port->partner_pd = usb_power_delivery_register(NULL, &desc);
+ port->partner_pd = usb_power_delivery_register(typec_partner_to_dev(port->partner), &desc);
if (IS_ERR(port->partner_pd)) {
dev_warn(typec->dev, "Failed to register partner PD device, port: %d\n", port_num);
return;
--
2.38.1.584.g0f3c55d4c2-goog