2022-11-22 08:19:42

by Jiucheng Xu

Subject: [PATCH] perf/amlogic: Fix build error for x86_64 allmodconfig

The driver misses including <linux/io.h>. It causes
compiling error "implicit declaration of function
'readl' and 'writel'" when make X86_64 allmodconfig.

Fixs: '2016e2113d35b ("perf/amlogic: Add support for
Amlogic meson G12 SoC DDR PMU driver")'
Signed-off-by: Jiucheng Xu <[email protected]>
---
drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
index c07c34f03cce..932802abd18c 100644
--- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
+++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
@@ -4,6 +4,7 @@
*/

#include <linux/err.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
--
2.25.1

2022-11-22 10:44:09

by Neil Armstrong

Subject: Re: [PATCH] perf/amlogic: Fix build error for x86_64 allmodconfig

On 22/11/2022 08:50, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
>
> Fixs: '2016e2113d35b ("perf/amlogic: Add support for
> Amlogic meson G12 SoC DDR PMU driver")'
> Signed-off-by: Jiucheng Xu <[email protected]>
> ---
> drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> index c07c34f03cce..932802abd18c 100644
> --- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> +++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> @@ -4,6 +4,7 @@
> */
>
> #include <linux/err.h>
> +#include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>


Reviewed-by: Neil Armstrong <[email protected]>