2022-11-22 10:12:54

by Jiucheng Xu

Subject: [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig

The driver misses including <linux/io.h>. It causes
compiling error "implicit declaration of function
'readl' and 'writel'" when make X86_64 allmodconfig.

Fixs: '2016e2113d35b ("perf/amlogic: Add support for
Amlogic meson G12 SoC DDR PMU driver")'
Signed-off-by: Jiucheng Xu <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
---
Changes v1 -> v2:
- Add the "Reviewed-by" tag
---
drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
index c07c34f03cce..932802abd18c 100644
--- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
+++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
@@ -4,6 +4,7 @@
*/

#include <linux/err.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
--
2.25.1

2022-11-22 11:40:21

by Will Deacon

Subject: Re: [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig

On Tue, 22 Nov 2022 16:40:28 +0800, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
>
> Amlogic meson G12 SoC DDR PMU driver")'
>
>
> [...]

Applied to will (for-next/perf), thanks!

[1/1] perf/amlogic: Fix build error for x86_64 allmodconfig
https://git.kernel.org/will/c/9d1d5cb32314

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev