2022-11-22 10:16:29

by Rajendra Nayak

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards

Add compatibles for the Pro SKU of the sc7280 CRD boards
which come with a Pro variant of the qcard.
The Pro qcard variant has smps9 from pm8350c ganged up with
smps7 and smps8.

Signed-off-by: Rajendra Nayak <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Matthias Kaehlcke <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 463509f0f23a..2550ab251f7b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -613,6 +613,11 @@ properties:
- const: google,hoglin
- const: qcom,sc7280

+ - description: Qualcomm Technologies, Inc. sc7280 CRD Pro platform (newest rev)
+ items:
+ - const: google,hoglin-sku1536
+ - const: qcom,sc7280
+
- description: Qualcomm Technologies, Inc. sc7280 IDP SKU1 platform
items:
- const: qcom,sc7280-idp
--
2.17.1


2022-11-22 10:39:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards

On 22/11/2022 10:49, Rajendra Nayak wrote:
> Add compatibles for the Pro SKU of the sc7280 CRD boards
> which come with a Pro variant of the qcard.
> The Pro qcard variant has smps9 from pm8350c ganged up with
> smps7 and smps8.
>
> Signed-off-by: Rajendra Nayak <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Matthias Kaehlcke <[email protected]>
> ---

What changed? It's v3 so there should be a changelog here. Same for patch 2.

Best regards,
Krzysztof

2022-11-22 10:44:24

by Rajendra Nayak

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards



On 11/22/2022 3:34 PM, Krzysztof Kozlowski wrote:
> On 22/11/2022 10:49, Rajendra Nayak wrote:
>> Add compatibles for the Pro SKU of the sc7280 CRD boards
>> which come with a Pro variant of the qcard.
>> The Pro qcard variant has smps9 from pm8350c ganged up with
>> smps7 and smps8.
>>
>> Signed-off-by: Rajendra Nayak <[email protected]>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>> Reviewed-by: Matthias Kaehlcke <[email protected]>
>> ---
>
> What changed? It's v3 so there should be a changelog here. Same for patch 2.

sorry forgot to mention, no change for this patch, only PATCH 2/2 had some
minor nits fixed based on feedback from Matthias.

>
> Best regards,
> Krzysztof
>