2022-11-22 12:42:45

by Yicong Yang

Subject: [PATCH 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list

From: Yicong Yang <[email protected]>

The PTT device can only support the devices on the same PCIe core,
within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
the devices on the root bus are from the same PCIe core, there are
cases that root ports from different PCIe core are sharing the same
bus. So add the checking when initialize the filters list.

Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
Signed-off-by: Yicong Yang <[email protected]>
---
drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
index 5d5526aa60c4..30f1525639b5 100644
--- a/drivers/hwtracing/ptt/hisi_ptt.c
+++ b/drivers/hwtracing/ptt/hisi_ptt.c
@@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)

static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)
{
+ struct pci_dev *root_port = pcie_find_root_port(pdev);
struct hisi_ptt_filter_desc *filter;
struct hisi_ptt *hisi_ptt = data;
+ u32 port_devid;
+
+ if (!root_port)
+ return 0;
+
+ port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);
+ if (port_devid < hisi_ptt->lower_bdf ||
+ port_devid > hisi_ptt->upper_bdf)
+ return 0;

/*
* We won't fail the probe if filter allocation failed here. The filters
--
2.24.0

2022-11-22 13:08:39

by Yicong Yang

Subject: [PATCH 2/2] MAINTAINERS: Update the entries for HiSilicon PTT device driver

From: Yicong Yang <[email protected]>

Add missing entries for the perf userspace part of this driver.
Also add Jonathan as the maintainer for his expertise on this
driver and PCIe stuffs.

Signed-off-by: Yicong Yang <[email protected]>
---
MAINTAINERS | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2585e7edc335..de3d0a5d9cb0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9263,11 +9263,15 @@ F: drivers/perf/hisilicon/hns3_pmu.c

HISILICON PTT DRIVER
M: Yicong Yang <[email protected]>
+M: Jonathan Cameron <[email protected]>
L: [email protected]
S: Maintained
F: Documentation/ABI/testing/sysfs-devices-hisi_ptt
F: Documentation/trace/hisi-ptt.rst
F: drivers/hwtracing/ptt/
+F: tools/perf/arch/arm64/util/hisi-ptt.c
+F: tools/perf/util/hisi-ptt*
+F: tools/perf/util/hisi-ptt-decoder/*

HISILICON QM DRIVER
M: Weili Qian <[email protected]>
--
2.24.0

2022-11-22 14:06:35

by Jonathan Cameron

Subject: Re: [PATCH 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list

On Tue, 22 Nov 2022 20:02:08 +0800
Yicong Yang <[email protected]> wrote:

> From: Yicong Yang <[email protected]>
>
> The PTT device can only support the devices on the same PCIe core,
> within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
> the devices on the root bus are from the same PCIe core, there are
> cases that root ports from different PCIe core are sharing the same
> bus. So add the checking when initialize the filters list.
>
> Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
> Signed-off-by: Yicong Yang <[email protected]>

Make sense to me.

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
> drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index 5d5526aa60c4..30f1525639b5 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)
>
> static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)
> {
> + struct pci_dev *root_port = pcie_find_root_port(pdev);
> struct hisi_ptt_filter_desc *filter;
> struct hisi_ptt *hisi_ptt = data;
> + u32 port_devid;
> +
> + if (!root_port)
> + return 0;
> +
> + port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);
> + if (port_devid < hisi_ptt->lower_bdf ||
> + port_devid > hisi_ptt->upper_bdf)
> + return 0;
>
> /*
> * We won't fail the probe if filter allocation failed here. The filters

2022-11-22 14:08:29

by Jonathan Cameron

Subject: Re: [PATCH 2/2] MAINTAINERS: Update the entries for HiSilicon PTT device driver

On Tue, 22 Nov 2022 20:02:09 +0800
Yicong Yang <[email protected]> wrote:

> From: Yicong Yang <[email protected]>
>
> Add missing entries for the perf userspace part of this driver.
> Also add Jonathan as the maintainer for his expertise on this
> driver and PCIe stuffs.
>
> Signed-off-by: Yicong Yang <[email protected]>

Acked-by: Jonathan Cameron <[email protected]>

> ---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2585e7edc335..de3d0a5d9cb0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9263,11 +9263,15 @@ F: drivers/perf/hisilicon/hns3_pmu.c
>
> HISILICON PTT DRIVER
> M: Yicong Yang <[email protected]>
> +M: Jonathan Cameron <[email protected]>
> L: [email protected]
> S: Maintained
> F: Documentation/ABI/testing/sysfs-devices-hisi_ptt
> F: Documentation/trace/hisi-ptt.rst
> F: drivers/hwtracing/ptt/
> +F: tools/perf/arch/arm64/util/hisi-ptt.c
> +F: tools/perf/util/hisi-ptt*
> +F: tools/perf/util/hisi-ptt-decoder/*
>
> HISILICON QM DRIVER
> M: Weili Qian <[email protected]>

2022-12-06 11:41:35

by Yicong Yang

Subject: Re: [PATCH 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list

Hi Mathieu,

Do we still have a chance to catch this cycle for these 2 patches?

Thanks!

On 2022/11/22 20:02, Yicong Yang wrote:
> From: Yicong Yang <[email protected]>
>
> The PTT device can only support the devices on the same PCIe core,
> within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
> the devices on the root bus are from the same PCIe core, there are
> cases that root ports from different PCIe core are sharing the same
> bus. So add the checking when initialize the filters list.
>
> Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
> Signed-off-by: Yicong Yang <[email protected]>
> ---
> drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index 5d5526aa60c4..30f1525639b5 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)
>
> static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)
> {
> + struct pci_dev *root_port = pcie_find_root_port(pdev);
> struct hisi_ptt_filter_desc *filter;
> struct hisi_ptt *hisi_ptt = data;
> + u32 port_devid;
> +
> + if (!root_port)
> + return 0;
> +
> + port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);
> + if (port_devid < hisi_ptt->lower_bdf ||
> + port_devid > hisi_ptt->upper_bdf)
> + return 0;
>
> /*
> * We won't fail the probe if filter allocation failed here. The filters
>

2022-12-06 11:59:06

by Suzuki K Poulose

Subject: Re: [PATCH 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list

Hi Yicong Yang

On 06/12/2022 11:34, Yicong Yang wrote:
> Hi Mathieu,
>
> Do we still have a chance to catch this cycle for these 2 patches?

Sorry, I have been handling the coresight tree this cycle (and will be
going forward). I have already sent the pull request to Greg. I am
afraid it is late for this cycle.

I can queue it for the next cycle.

Suzuki


>
> Thanks!
>
> On 2022/11/22 20:02, Yicong Yang wrote:
>> From: Yicong Yang <[email protected]>
>>
>> The PTT device can only support the devices on the same PCIe core,
>> within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
>> the devices on the root bus are from the same PCIe core, there are
>> cases that root ports from different PCIe core are sharing the same
>> bus. So add the checking when initialize the filters list.
>>
>> Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
>> Signed-off-by: Yicong Yang <[email protected]>
>> ---
>> drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
>> index 5d5526aa60c4..30f1525639b5 100644
>> --- a/drivers/hwtracing/ptt/hisi_ptt.c
>> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
>> @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)
>>
>> static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)
>> {
>> + struct pci_dev *root_port = pcie_find_root_port(pdev);
>> struct hisi_ptt_filter_desc *filter;
>> struct hisi_ptt *hisi_ptt = data;
>> + u32 port_devid;
>> +
>> + if (!root_port)
>> + return 0;
>> +
>> + port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);
>> + if (port_devid < hisi_ptt->lower_bdf ||
>> + port_devid > hisi_ptt->upper_bdf)
>> + return 0;
>>
>> /*
>> * We won't fail the probe if filter allocation failed here. The filters
>>

2022-12-06 12:45:11

by Yicong Yang

Subject: Re: [PATCH 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list

On 2022/12/6 19:46, Suzuki K Poulose wrote:
> Hi Yicong Yang
>
> On 06/12/2022 11:34, Yicong Yang wrote:
>> Hi Mathieu,
>>
>> Do we still have a chance to catch this cycle for these 2 patches?
>
> Sorry, I have been handling the coresight tree this cycle (and will be
> going forward). I have already sent the pull request to Greg. I am
> afraid it is late for this cycle.
>
> I can queue it for the next cycle.
>

Thanks for the information.
It's ok, I'll resend in the next cycle.

Thanks,
Yicong

>>
>> Thanks!
>>
>> On 2022/11/22 20:02, Yicong Yang wrote:
>>> From: Yicong Yang <[email protected]>
>>>
>>> The PTT device can only support the devices on the same PCIe core,
>>> within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
>>> the devices on the root bus are from the same PCIe core, there are
>>> cases that root ports from different PCIe core are sharing the same
>>> bus. So add the checking when initialize the filters list.
>>>
>>> Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
>>> Signed-off-by: Yicong Yang <[email protected]>
>>> ---
>>>   drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
>>> index 5d5526aa60c4..30f1525639b5 100644
>>> --- a/drivers/hwtracing/ptt/hisi_ptt.c
>>> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
>>> @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)
>>>     static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)
>>>   {
>>> +    struct pci_dev *root_port = pcie_find_root_port(pdev);
>>>       struct hisi_ptt_filter_desc *filter;
>>>       struct hisi_ptt *hisi_ptt = data;
>>> +    u32 port_devid;
>>> +
>>> +    if (!root_port)
>>> +        return 0;
>>> +
>>> +    port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);
>>> +    if (port_devid < hisi_ptt->lower_bdf ||
>>> +        port_devid > hisi_ptt->upper_bdf)
>>> +        return 0;
>>>         /*
>>>        * We won't fail the probe if filter allocation failed here. The filters
>>>
>
>
> .