2022-11-22 14:43:35

by Edmund Berenson

Subject: [PATCH v4] dt-bindings: iio: adc: ad7923: adjust documentation

- The ad7927 is fully compatible with ad7928 driver, add
documentation for device.
- ad7923 and ad7924 are treated the same in the driver, show
the relationship in the documentation.

Suggested-by: Lukasz Zemla <[email protected]>
Signed-off-by: Edmund Berenson <[email protected]>
---
.../bindings/iio/adc/adi,ad7923.yaml | 25 ++++++++++++-------
1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
index 07f9d1c09c7d..b6e2f1b41739 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
@@ -11,7 +11,7 @@ maintainers:

description: |
Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
- AD7918, AD7928 8 Channels ADCs.
+ AD7918, AD7927, AD7928 8 Channels ADCs.

Specifications about the part can be found at:
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
@@ -20,14 +20,21 @@ description: |

properties:
compatible:
- enum:
- - adi,ad7904
- - adi,ad7914
- - adi,ad7923
- - adi,ad7924
- - adi,ad7908
- - adi,ad7918
- - adi,ad7928
+ oneOf:
+ - const: adi,ad7904
+ - const: adi,ad7908
+ - const: adi,ad7914
+ - const: adi,ad7918
+ - const: adi,ad7923
+ - const: adi,ad7924
+ deprecated: true
+ - const: adi,ad7928
+ - items:
+ - const: adi,ad7924
+ - const: adi,ad7923
+ - items:
+ - const: adi,ad7927
+ - const: adi,ad7928

reg:
maxItems: 1
--
2.37.4

2022-11-22 15:55:46

by Krzysztof Kozlowski

Subject: Re: [PATCH v4] dt-bindings: iio: adc: ad7923: adjust documentation

On 22/11/2022 15:05, Edmund Berenson wrote:
> - The ad7927 is fully compatible with ad7928 driver, add
> documentation for device.
> - ad7923 and ad7924 are treated the same in the driver, show
> the relationship in the documentation.
>
> Suggested-by: Lukasz Zemla <[email protected]>
> Signed-off-by: Edmund Berenson <[email protected]>
> ---
> .../bindings/iio/adc/adi,ad7923.yaml | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> index 07f9d1c09c7d..b6e2f1b41739 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -11,7 +11,7 @@ maintainers:
>
> description: |
> Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> - AD7918, AD7928 8 Channels ADCs.
> + AD7918, AD7927, AD7928 8 Channels ADCs.
>
> Specifications about the part can be found at:
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> @@ -20,14 +20,21 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - adi,ad7904
> - - adi,ad7914
> - - adi,ad7923
> - - adi,ad7924
> - - adi,ad7908
> - - adi,ad7918
> - - adi,ad7928
> + oneOf:
> + - const: adi,ad7904
> + - const: adi,ad7908
> + - const: adi,ad7914
> + - const: adi,ad7918
> + - const: adi,ad7923

Keep all others as enum.


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof