2022-11-22 16:38:32

by Philippe Schenker

[permalink] [raw]
Subject: [PATCH v1 0/5] Unify USB Over Current Settings on Toradex Boards

From: Philippe Schenker <[email protected]>


This patchset intends to disable the USB Over Current for Toradex i.MX
boards using the USB chipidea driver.

We do this on the Carrier-Board device-trees due to the reason, that if
a customer of us inheriting the module-level device-tree (named -.dtsi)
does not inherit settings from us that may be incorrect for his
use-case.


Philippe Schenker (5):
ARM: dts: apalis-imx6: Disable usb over-current
ARM: dts: colibri-imx6: Disable usb over-current
ARM: dts: colibri-imx6ull: Disable usb over-current
ARM: dts: colibri-imx7: Disable usb over-current
arm64: dts: verdin-imx8mm: Disable usb over-current

arch/arm/boot/dts/imx6dl-colibri-aster.dts | 2 ++
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 2 ++
arch/arm/boot/dts/imx6dl-colibri-iris.dts | 2 ++
arch/arm/boot/dts/imx6q-apalis-eval.dts | 2 ++
arch/arm/boot/dts/imx6q-apalis-ixora-v1.2.dts | 2 ++
arch/arm/boot/dts/imx6q-apalis-ixora.dts | 2 ++
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 -
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 1 -
arch/arm/boot/dts/imx6ull-colibri-aster.dtsi | 2 ++
arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 2 ++
arch/arm/boot/dts/imx6ull-colibri-iris.dtsi | 2 ++
arch/arm/boot/dts/imx7-colibri-aster.dtsi | 1 +
arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 1 +
arch/arm/boot/dts/imx7-colibri-iris-v2.dtsi | 1 +
arch/arm/boot/dts/imx7-colibri-iris.dtsi | 1 +
arch/arm/boot/dts/imx7d-colibri-aster.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-emmc-aster.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-emmc-iris.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-emmc.dtsi | 1 +
arch/arm/boot/dts/imx7d-colibri-eval-v3.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-iris-v2.dts | 1 +
arch/arm/boot/dts/imx7d-colibri-iris.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 2 --
26 files changed, 33 insertions(+), 4 deletions(-)

--
2.38.1


2022-11-22 16:52:52

by Philippe Schenker

[permalink] [raw]
Subject: [PATCH v1 2/5] ARM: dts: colibri-imx6: Disable usb over-current

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards
used by Toradex. Do this as we don't want to use this functionality on
our Carrier Boards and to leave it open to someone who includes our
module-level device-trees.

Remove the now obsolete disable-over-current flag from module-level
device-tree imx6qdl-colibri.dtsi and leave it as already mentioned to
the people actually implementing the carrier-board to implement this.

This will prevent the warning "No over current polarity defined" from
being printed on boot.

Signed-off-by: Philippe Schenker <[email protected]>
---

arch/arm/boot/dts/imx6dl-colibri-aster.dts | 2 ++
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 2 ++
arch/arm/boot/dts/imx6dl-colibri-iris.dts | 2 ++
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 1 -
4 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6dl-colibri-aster.dts b/arch/arm/boot/dts/imx6dl-colibri-aster.dts
index a28e083f29d5..82a0d1a28d12 100644
--- a/arch/arm/boot/dts/imx6dl-colibri-aster.dts
+++ b/arch/arm/boot/dts/imx6dl-colibri-aster.dts
@@ -99,10 +99,12 @@ &uart3 {
};

&usbh1 {
+ disable-over-current;
status = "okay";
};

&usbotg {
+ disable-over-current;
status = "okay";
};

diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
index a02981d4a3fc..f50a26dd34c0 100644
--- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
@@ -111,10 +111,12 @@ &uart3 {
};

&usbh1 {
+ disable-over-current;
status = "okay";
};

&usbotg {
+ disable-over-current;
status = "okay";
};

diff --git a/arch/arm/boot/dts/imx6dl-colibri-iris.dts b/arch/arm/boot/dts/imx6dl-colibri-iris.dts
index c5797ff35b71..4303c88bb2a9 100644
--- a/arch/arm/boot/dts/imx6dl-colibri-iris.dts
+++ b/arch/arm/boot/dts/imx6dl-colibri-iris.dts
@@ -138,10 +138,12 @@ &uart3 {
};

&usbh1 {
+ disable-over-current;
status = "okay";
};

&usbotg {
+ disable-over-current;
status = "okay";
};

diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..f894d6907604 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -684,7 +684,6 @@ &usbh1 {

/* Colibri USBC */
&usbotg {
- disable-over-current;
dr_mode = "otg";
extcon = <0>, <&extcon_usbc_det>;
status = "disabled";
--
2.38.1

2022-12-31 07:58:54

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 0/5] Unify USB Over Current Settings on Toradex Boards

On Tue, Nov 22, 2022 at 04:54:33PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <[email protected]>
>
>
> This patchset intends to disable the USB Over Current for Toradex i.MX
> boards using the USB chipidea driver.
>
> We do this on the Carrier-Board device-trees due to the reason, that if
> a customer of us inheriting the module-level device-tree (named -.dtsi)
> does not inherit settings from us that may be incorrect for his
> use-case.
>
>
> Philippe Schenker (5):
> ARM: dts: apalis-imx6: Disable usb over-current
> ARM: dts: colibri-imx6: Disable usb over-current
> ARM: dts: colibri-imx6ull: Disable usb over-current
> ARM: dts: colibri-imx7: Disable usb over-current
> arm64: dts: verdin-imx8mm: Disable usb over-current

Applied all, thanks!