2022-11-23 10:20:01

by Manoj Sai

[permalink] [raw]
Subject: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc

Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
get reduced from 36 seconds to 20 seconds.

Signed-off-by: Manoj Sai <[email protected]>
Signed-off-by: Da Xue <[email protected]>
Signed-off-by: dsx724 <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index 2f4b1b2e3ac7..8fd808a0df85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -735,7 +735,7 @@ &spi1 {
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10000000>;
+ spi-max-frequency = <30000000>;
};
};

--
2.25.1


2022-11-23 14:22:05

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc

Hi Manoj,

Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
>
> Signed-off-by: Manoj Sai <[email protected]>
> Signed-off-by: Da Xue <[email protected]>
> Signed-off-by: dsx724 <[email protected]>

who are these other people? :-)

I.e. it looks like you're the author of the patch,
and so it should only have your Signed-off-by line.

If Da Xue and dsx724 have tested / reviewed the change, they
should respond individually to the posted patch with
either a "Reviewed-by: ..." or "Tested-by: ..." line.


Thanks
Heiko

> ---
> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> index 2f4b1b2e3ac7..8fd808a0df85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> @@ -735,7 +735,7 @@ &spi1 {
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <10000000>;
> + spi-max-frequency = <30000000>;
> };
> };
>
>




2022-11-23 14:25:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc

On 23/11/2022 15:04, Heiko Stuebner wrote:
> Hi Manoj,
>
> Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
>> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
>> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
>> get reduced from 36 seconds to 20 seconds.
>>
>> Signed-off-by: Manoj Sai <[email protected]>
>> Signed-off-by: Da Xue <[email protected]>
>> Signed-off-by: dsx724 <[email protected]>
>
> who are these other people? :-)

moreconfused.com :)

Best regards,
Krzysztof

2022-11-24 07:36:42

by Manoj Sai

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc

Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
get reduced from 36 seconds to 20 seconds.

Signed-off-by: Manoj Sai <[email protected]>
---
Changes for v2:
- removed irrelevant members from the Signed-Off-By section in the commit message.
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index 2f4b1b2e3ac7..8fd808a0df85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -735,7 +735,7 @@ &spi1 {
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10000000>;
+ spi-max-frequency = <30000000>;
};
};

--
2.25.1

2023-01-10 14:22:00

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc

On Thu, 24 Nov 2022 12:57:14 +0530, Manoj Sai wrote:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
>
>

Applied, thanks!

[1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
commit: 36861fd1fa05fb9b5d9654e6ad3d325a7671b1e1

Best regards,
--
Heiko Stuebner <[email protected]>