2022-11-23 10:56:44

by Owen Yang

Subject: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie

Add an entry in the device tree binding for sc7280-zombie.

Signed-off-by: Owen Yang <[email protected]>
---

Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 463509f0f23a..7ec6240311db 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -655,6 +655,16 @@ properties:
- const: google,villager-sku512
- const: qcom,sc7280

+ - description: Google Zombie (newest rev)
+ items:
+ - const: google,zombie
+ - const: qcom,sc7280
+
+ - description: Google Zombie with LTE (newest rev)
+ items:
+ - const: google,zombie-sku512
+ - const: qcom,sc7280
+
- items:
- enum:
- lenovo,flex-5g
--
2.17.1

2022-11-23 11:09:58

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie

On 23/11/2022 11:11, Owen Yang wrote:
> Add an entry in the device tree binding for sc7280-zombie.

Subject: drop second, redundant "DT binding". This is obvious from the
prefix.

With subject fixed:


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-11-23 14:45:02

by Matthias Kaehlcke

Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie

On Wed, Nov 23, 2022 at 06:11:12PM +0800, Owen Yang wrote:

> Subject: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie

nit: s/Adding/Add/ besides dropping the redundant 'DT binding for' as
requested by Krzysztof.

Please version your patches. This is v3 if I'm keeping track correctly, so
the next one with the fixed subject should be v4.

> Add an entry in the device tree binding for sc7280-zombie.
>
> Signed-off-by: Owen Yang <[email protected]>
> ---
>
> Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 463509f0f23a..7ec6240311db 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -655,6 +655,16 @@ properties:
> - const: google,villager-sku512
> - const: qcom,sc7280
>
> + - description: Google Zombie (newest rev)
> + items:
> + - const: google,zombie
> + - const: qcom,sc7280
> +
> + - description: Google Zombie with LTE (newest rev)
> + items:
> + - const: google,zombie-sku512
> + - const: qcom,sc7280
> +
> - items:
> - enum:
> - lenovo,flex-5g
> --
> 2.17.1
>