2022-11-24 17:05:28

by Ricardo Ribalda

[permalink] [raw]
Subject: [PATCH v1 0/1] regulator: da9211: Fix crash when irqs are pre-enabled

If the system does not come from reset (like when it is kexec()), the
regulator might have an IRQ waiting for us.

If we enable the IRQ handler before its structures are ready, we crash.

To: Support Opensource <[email protected]>
To: Liam Girdwood <[email protected]>
To: Mark Brown <[email protected]>
Cc: [email protected]
Signed-off-by: Ricardo Ribalda <[email protected]>

---
Ricardo Ribalda (1):
regulator: da9211: Use irq handler when ready

drivers/regulator/da9211-regulator.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 4312098baf37ee17a8350725e6e0d0e8590252d4
change-id: 20221124-da9211-4b8904b4feb5

Best regards,
--
Ricardo Ribalda <[email protected]>


2022-11-24 17:23:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 0/1] regulator: da9211: Fix crash when irqs are pre-enabled

On Thu, Nov 24, 2022 at 05:45:30PM +0100, Ricardo Ribalda wrote:
> If the system does not come from reset (like when it is kexec()), the
> regulator might have an IRQ waiting for us.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.


Attachments:
(No filename) (492.00 B)
signature.asc (499.00 B)
Download all attachments

2022-11-24 17:50:52

by Ricardo Ribalda

[permalink] [raw]
Subject: Re: [PATCH v1 0/1] regulator: da9211: Fix crash when irqs are pre-enabled

Hi Mark


On Thu, 24 Nov 2022 at 17:52, Mark Brown <[email protected]> wrote:
>
> On Thu, Nov 24, 2022 at 05:45:30PM +0100, Ricardo Ribalda wrote:
> > If the system does not come from reset (like when it is kexec()), the
> > regulator might have an IRQ waiting for us.
>
> Please don't send cover letters for single patches, if there is anything
> that needs saying put it in the changelog of the patch or after the ---
> if it's administrative stuff. This reduces mail volume and ensures that
> any important information is recorded in the changelog rather than being
> lost.

I am using the "b4 prep" workflow and I think there is no way to
disable the cover-letter.

Let me ask at [email protected] if they plan to support "old lore
links after the ---" for single patch

Thanks!


--
Ricardo Ribalda

2022-11-29 17:13:10

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 0/1] regulator: da9211: Fix crash when irqs are pre-enabled

On Thu, 24 Nov 2022 17:45:30 +0100, Ricardo Ribalda wrote:
> If the system does not come from reset (like when it is kexec()), the
> regulator might have an IRQ waiting for us.
>
> If we enable the IRQ handler before its structures are ready, we crash.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: da9211: Use irq handler when ready
commit: 02228f6aa6a64d588bc31e3267d05ff184d772eb

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark