2022-11-24 06:22:22

by Genjian

Subject: [PATCH] MIPS: Restore symbol versions for copy_page_cpu and clear_page_cpu

From: Genjian Zhang <[email protected]>

The mips build generates two warnings:

WARNING: modpost: EXPORT symbol "clear_page_cpu" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: modpost: EXPORT symbol "copy_page_cpu" [vmlinux] version generation failed, symbol will not be versioned.

Add their prototypes to be defined in asm-prototypes.h, so that
genksyms knows the types of these symbols and can generate CRCs for
them.

Reported-by: k2ci <[email protected]>
Signed-off-by: Genjian Zhang <[email protected]>
---
arch/mips/include/asm/asm-prototypes.h | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/mips/include/asm/asm-prototypes.h b/arch/mips/include/asm/asm-prototypes.h
index f901ed043c71..8e8fc38b0941 100644
--- a/arch/mips/include/asm/asm-prototypes.h
+++ b/arch/mips/include/asm/asm-prototypes.h
@@ -6,3 +6,6 @@
#include <linux/uaccess.h>
#include <asm/ftrace.h>
#include <asm/mmu_context.h>
+
+extern void clear_page_cpu(void *page);
+extern void copy_page_cpu(void *to, void *from);
--
2.25.1

2022-12-01 11:05:55

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: Restore symbol versions for copy_page_cpu and clear_page_cpu

On Thu, Nov 24, 2022 at 01:58:16PM +0800, Genjian wrote:
> From: Genjian Zhang <[email protected]>
>
> The mips build generates two warnings:
>
> WARNING: modpost: EXPORT symbol "clear_page_cpu" [vmlinux] version generation failed, symbol will not be versioned.
> WARNING: modpost: EXPORT symbol "copy_page_cpu" [vmlinux] version generation failed, symbol will not be versioned.
>
> Add their prototypes to be defined in asm-prototypes.h, so that
> genksyms knows the types of these symbols and can generate CRCs for
> them.
>
> Reported-by: k2ci <[email protected]>
> Signed-off-by: Genjian Zhang <[email protected]>
> ---
> arch/mips/include/asm/asm-prototypes.h | 3 +++
> 1 file changed, 3 insertions(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]