2022-11-24 12:06:32

by Sudeep Holla

[permalink] [raw]
Subject: Re: Re：Re : [PATCH 3/3] arm_scpi: modify to support acpi

Hi Wang,


Please use text for your emails. I think it is html and I can't read it.

On Thu, Nov 24, 2022 at 07:17:32PM +0800, 王洪辉 wrote:
> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU temp & freq, This patch is for the case, I had test ok on Phytium FT2000/4 plantform. And please append Patch V2 3/3.
>
>                                                                                     ---原始邮件---
> 发件人:&quot;Sudeep&nbsp;Holla&quot;<[email protected]&gt;
> 发送时间:2022年11月24日(星期四)&nbsp;晚上7:10
> 收件人:&quot;Wang&nbsp;Honghui&quot;<[email protected]&gt;;
> 主题:&nbsp;[PATCH&nbsp;3/3]&nbsp;arm_scpi:&nbsp;modify&nbsp;to&nbsp;support&nbsp;acpi
> Hi&nbsp;W&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
> ------------------&nbsp;Original&nbsp;------------------
> From:&nbsp;&quot;Sudeep Holla&quot;<[email protected]&gt;
> Date:&nbsp;Thu, Nov 24, 2022 07:10 PM
> To:&nbsp;&quot;Wang Honghui&quot;<[email protected]&gt;;
> Cc:&nbsp;&quot;Cristian Maruss&quot;<[email protected]&gt;;&quot;Jassi Brar&quot;<[email protected]&gt;;&quot;Sudeep Holla&quot;<[email protected]&gt;;&quot;linux-arm-kernel&quot;<[email protected]&gt;;&quot;linux-kernel&quot;<[email protected]&gt;;
> Subject:&nbsp;Re: [PATCH 3/3] arm_scpi: modify to support acpi

Doing %s/&nbsp;/ /g gave me:

> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU
> temp &amp; freq, This patch is for the case, I had test ok on Phytium
> FT2000/4 plantform. And please append Patch V2 3/3.

Let me repeat. You must use PCC driver without any phytium ft2000/4 platform
code. All platform specific code and SCPI protocol must be hidden/abstracted
in ACPI AML.

Your changes are not acceptable for upstream. No change will be allowed in
SCPI for ACPI as it needs to go in the firmware tables.

Also I noticed drivers/mailbox/phytium_mailbox.c doesn't exist. So this patch
is wrong in so many ways. Please check on how to represent phytium_mailbox
hardware using ACPI PCC and add AML code that uses SCPI to achieve whatever
you want. You may want to check on how to use PCC OpRegion as well in ACPI.

--
Regards,
Sudeep