2022-11-24 16:00:05

by Cosmin Tanislav

Subject: [PATCH] iio: addac: ad74115: remove unused ad74115_dac_slew_rate_hz_tbl

This table was supposed to be used for handling the DAC rate, but it
ended up being unused. Remove it.

Signed-off-by: Cosmin Tanislav <[email protected]>
Reported-by: kernel test robot <[email protected]>
Fixes: 48ea75598db2 ("iio: addac: add AD74115 driver")
---
drivers/iio/addac/ad74115.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
index 383b92e7b682..e6bc5eb3788d 100644
--- a/drivers/iio/addac/ad74115.c
+++ b/drivers/iio/addac/ad74115.c
@@ -317,10 +317,6 @@ static const unsigned int ad74115_dac_rate_step_tbl[][3] = {
{ AD74115_SLEW_MODE_LINEAR, AD74115_SLEW_STEP_22_2_PERCENT, AD74115_SLEW_RATE_240KHZ },
};

-static const unsigned int ad74115_dac_slew_rate_hz_tbl[] = {
- 4000, 64000, 150000, 240000
-};
-
static const unsigned int ad74115_rtd_excitation_current_ua_tbl[] = {
250, 500, 750, 1000
};
--
2.38.1

2022-11-24 19:57:35

by Jonathan Cameron

Subject: Re: [PATCH] iio: addac: ad74115: remove unused ad74115_dac_slew_rate_hz_tbl

On Thu, 24 Nov 2022 17:25:59 +0200
Cosmin Tanislav <[email protected]> wrote:

> This table was supposed to be used for handling the DAC rate, but it
> ended up being unused. Remove it.
>
> Signed-off-by: Cosmin Tanislav <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 48ea75598db2 ("iio: addac: add AD74115 driver")
Dropped fixes tag as it's not going to do anything bad other than warning
without this and to put it likely fixes tags against recent patches have
been causing me a world of pain this week.

Applied on basis its safe enough even without time soaking in next.

Jonathan

> ---
> drivers/iio/addac/ad74115.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
> index 383b92e7b682..e6bc5eb3788d 100644
> --- a/drivers/iio/addac/ad74115.c
> +++ b/drivers/iio/addac/ad74115.c
> @@ -317,10 +317,6 @@ static const unsigned int ad74115_dac_rate_step_tbl[][3] = {
> { AD74115_SLEW_MODE_LINEAR, AD74115_SLEW_STEP_22_2_PERCENT, AD74115_SLEW_RATE_240KHZ },
> };
>
> -static const unsigned int ad74115_dac_slew_rate_hz_tbl[] = {
> - 4000, 64000, 150000, 240000
> -};
> -
> static const unsigned int ad74115_rtd_excitation_current_ua_tbl[] = {
> 250, 500, 750, 1000
> };