2022-11-24 15:41:31

by Cosmin Tanislav

Subject: [PATCH] iio: addac: ad74413r: fix blank line after declaration warning

Checkpatch wants a blank line after all declarations. Add it now,
even though the patch has already been submitted.

Signed-off-by: Cosmin Tanislav <[email protected]>
Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
---
drivers/iio/addac/ad74413r.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 61030053cbea..f32c8c2fb26d 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
st->chip_info = device_get_match_data(&spi->dev);
if (!st->chip_info) {
const struct spi_device_id *id = spi_get_device_id(spi);
+
if (id)
st->chip_info =
(struct ad74413r_chip_info *)id->driver_data;
--
2.38.1

2022-11-24 19:57:23

by Jonathan Cameron

Subject: Re: [PATCH] iio: addac: ad74413r: fix blank line after declaration warning

On Thu, 24 Nov 2022 17:30:49 +0200
Cosmin Tanislav <[email protected]> wrote:

> Checkpatch wants a blank line after all declarations. Add it now,
> even though the patch has already been submitted.
>
> Signed-off-by: Cosmin Tanislav <[email protected]>
> Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
Dropped fixes tag as this is just cosmetic.

Applied.
> ---
> drivers/iio/addac/ad74413r.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index 61030053cbea..f32c8c2fb26d 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
> st->chip_info = device_get_match_data(&spi->dev);
> if (!st->chip_info) {
> const struct spi_device_id *id = spi_get_device_id(spi);
> +
> if (id)
> st->chip_info =
> (struct ad74413r_chip_info *)id->driver_data;