2022-11-28 22:07:03

by Jonathan Neuschäfer

[permalink] [raw]
Subject: [PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes

My recently merged nuvoton,wpcm450-fiu DT binding caused some
dt_binding_check issues in linux-next. This series attempts to fix them
before the breakage spreads any further.

Thanks to Conor Dooley, who notified me.

Jonathan Neuschäfer (2):
spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus
include)
spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing
reg property)

.../devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.35.1


2022-11-28 22:11:21

by Jonathan Neuschäfer

[permalink] [raw]
Subject: [PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Conor Dooley <[email protected]>
Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@ unevaluatedProperties: false

examples:
- |
- #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
spi@c8000000 {
compatible = "nuvoton,wpcm450-fiu";
reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
#address-cells = <1>;
#size-cells = <0>;
reg-names = "control", "memory";
- clocks = <&clk WPCM450_CLK_FIU>;
+ clocks = <&clk 0>;
nuvoton,shm = <&shm>;

flash@0 {
--
2.35.1

2022-11-29 08:30:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> The nuvoton,wpcm450-fiu binding's example includes
> nuvoton,wpcm450-clk.h, which has not been merged yet,
> thus causing a dt_binding_check error on -next.
>
> Fix this error by simply hardcoding the clock index in the example,
> before the breakage spreads any further.
>
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Reported-by: Conor Dooley <[email protected]>

Report came from Rob:

Reported-by: Rob Herring <[email protected]>

> Signed-off-by: Jonathan Neuschäfer <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof