PUD values used for UFS, SPI and UART are not reflecting
the default values recommended by FSD HW UM. Therefore,
changing the same to comply with HW UM recommendation.
Signed-off-by: Padmanabhan Rajanbabu <[email protected]>
---
arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
index e3852c946352..2b367bde45b8 100644
--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
@@ -54,14 +54,14 @@
ufs_rst_n: ufs-rst-n-pins {
samsung,pins = "gpf5-0";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+ samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
ufs_refclk_out: ufs-refclk-out-pins {
samsung,pins = "gpf5-1";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+ samsung,pin-pud = <FSD_PIN_PULL_UP>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
};
@@ -308,35 +308,35 @@
uart0_data: uart0-data-pins {
samsung,pins = "gpb7-0", "gpb7-1";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+ samsung,pin-pud = <FSD_PIN_PULL_UP>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
uart1_data: uart1-data-pins {
samsung,pins = "gpb7-4", "gpb7-5";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+ samsung,pin-pud = <FSD_PIN_PULL_UP>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
spi0_bus: spi0-bus-pins {
samsung,pins = "gpb4-0", "gpb4-2", "gpb4-3";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_UP>;
+ samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
spi1_bus: spi1-bus-pins {
samsung,pins = "gpb4-4", "gpb4-6", "gpb4-7";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_UP>;
+ samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
spi2_bus: spi2-bus-pins {
samsung,pins = "gpb5-0", "gpb5-2", "gpb5-3";
samsung,pin-function = <FSD_PIN_FUNC_2>;
- samsung,pin-pud = <FSD_PIN_PULL_UP>;
+ samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};
};
--
2.17.1
On 29/11/2022 10:55, Padmanabhan Rajanbabu wrote:
> PUD values used for UFS, SPI and UART are not reflecting
> the default values recommended by FSD HW UM. Therefore,
> changing the same to comply with HW UM recommendation.
>
> Signed-off-by: Padmanabhan Rajanbabu <[email protected]>
> ---
> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 14 +++++++-------
This patch does not apply, please rebase on my for-next or linux-next
(once released).
Best regards,
Krzysztof
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 26 December 2022 08:41 PM
> To: Padmanabhan Rajanbabu <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH] arm64: dts: fsd: fix PUD values as per FSD HW UM
>
> On 29/11/2022 10:55, Padmanabhan Rajanbabu wrote:
> > PUD values used for UFS, SPI and UART are not reflecting the default
> > values recommended by FSD HW UM. Therefore, changing the same to
> > comply with HW UM recommendation.
> >
> > Signed-off-by: Padmanabhan Rajanbabu <[email protected]>
> > ---
> > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 14 +++++++-------
>
> This patch does not apply, please rebase on my for-next or linux-next (once
> released).
Okay, I've rebased on your for-next branch and posted the v2 patch.
>
> Best regards,
> Krzysztof
Thanks,
Padmanabhan R.