The current comment on wakeup-source is a little confusing because
the word deprecated can be interpreted at first glance to mean that
wakeup-source is deprecated. Also mentioning the obsolete property
confuses more than it helps. Therefore, the comment should be removed
completely because the enable-sdio-wakeup property is not used in
any current DTs.
Signed-off-by: Christoph Niedermaier <[email protected]>
---
Cc: Ulf Hansson <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: - Instead of changing the comment, remove it
---
Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 802e3ca8be4d..e82c00368088 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -293,7 +293,6 @@ properties:
description:
SDIO only. Preserves card power during a suspend/resume cycle.
- # Deprecated: enable-sdio-wakeup
wakeup-source:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.11.0
On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier
<[email protected]> wrote:
>
> The current comment on wakeup-source is a little confusing because
> the word deprecated can be interpreted at first glance to mean that
> wakeup-source is deprecated. Also mentioning the obsolete property
> confuses more than it helps. Therefore, the comment should be removed
> completely because the enable-sdio-wakeup property is not used in
> any current DTs.
>
> Signed-off-by: Christoph Niedermaier <[email protected]>
> ---
> Cc: Ulf Hansson <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Marek Vasut <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> To: [email protected]
> ---
> V2: - Instead of changing the comment, remove it
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 802e3ca8be4d..e82c00368088 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -293,7 +293,6 @@ properties:
> description:
> SDIO only. Preserves card power during a suspend/resume cycle.
>
> - # Deprecated: enable-sdio-wakeup
> wakeup-source:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
This looks good to me!
However, let's also drop the reference to the property from
Documentation/devicetree/bindings/power/wakeup-source.txt.
Kind regards
Uffe
From: Ulf Hansson [mailto:[email protected]]
Sent: Wednesday, November 30, 2022 12:40 PM
> On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier<[email protected]> wrote:
>>
>> The current comment on wakeup-source is a little confusing because
>> the word deprecated can be interpreted at first glance to mean that
>> wakeup-source is deprecated. Also mentioning the obsolete property
>> confuses more than it helps. Therefore, the comment should be removed
>> completely because the enable-sdio-wakeup property is not used in
>> any current DTs.
>>
>> Signed-off-by: Christoph Niedermaier <[email protected]>
>> ---
>> Cc: Ulf Hansson <[email protected]>
>> Cc: Rob Herring <[email protected]>
>> Cc: Krzysztof Kozlowski <[email protected]>
>> Cc: Marek Vasut <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> To: [email protected]
>> ---
>> V2: - Instead of changing the comment, remove it
>> ---
>> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> index 802e3ca8be4d..e82c00368088 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> @@ -293,7 +293,6 @@ properties:
>> description:
>> SDIO only. Preserves card power during a suspend/resume cycle.
>>
>> - # Deprecated: enable-sdio-wakeup
>> wakeup-source:
>> $ref: /schemas/types.yaml#/definitions/flag
>> description:
>
> This looks good to me!
>
> However, let's also drop the reference to the property from
> Documentation/devicetree/bindings/power/wakeup-source.txt.
Should I include this in a version 3 or should I send a separate patch?
Regards
Christoph
On Wed, 30 Nov 2022 at 12:55, Christoph Niedermaier
<[email protected]> wrote:
>
> From: Ulf Hansson [mailto:[email protected]]
> Sent: Wednesday, November 30, 2022 12:40 PM
> > On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier<[email protected]> wrote:
> >>
> >> The current comment on wakeup-source is a little confusing because
> >> the word deprecated can be interpreted at first glance to mean that
> >> wakeup-source is deprecated. Also mentioning the obsolete property
> >> confuses more than it helps. Therefore, the comment should be removed
> >> completely because the enable-sdio-wakeup property is not used in
> >> any current DTs.
> >>
> >> Signed-off-by: Christoph Niedermaier <[email protected]>
> >> ---
> >> Cc: Ulf Hansson <[email protected]>
> >> Cc: Rob Herring <[email protected]>
> >> Cc: Krzysztof Kozlowski <[email protected]>
> >> Cc: Marek Vasut <[email protected]>
> >> Cc: [email protected]
> >> Cc: [email protected]
> >> Cc: [email protected]
> >> To: [email protected]
> >> ---
> >> V2: - Instead of changing the comment, remove it
> >> ---
> >> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> index 802e3ca8be4d..e82c00368088 100644
> >> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> >> @@ -293,7 +293,6 @@ properties:
> >> description:
> >> SDIO only. Preserves card power during a suspend/resume cycle.
> >>
> >> - # Deprecated: enable-sdio-wakeup
> >> wakeup-source:
> >> $ref: /schemas/types.yaml#/definitions/flag
> >> description:
> >
> > This looks good to me!
> >
> > However, let's also drop the reference to the property from
> > Documentation/devicetree/bindings/power/wakeup-source.txt.
>
> Should I include this in a version 3 or should I send a separate patch?
Please add it in v3, so we can remove the confusing things altogether.
Kind regards
Uffe