2022-12-01 03:43:14

by Yajun Deng

Subject: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare()

arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
just a wrapper for local_fiq_enable().

The local_fiq_enable() was already called before cpu_startup_entry().

So remove redundant arch_cpu_idle_prepare().

Signed-off-by: Yajun Deng <[email protected]>
---
arch/arm/kernel/process.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index f811733a8fc5..e3f490ab95f4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -81,11 +81,6 @@ void arch_cpu_idle(void)
raw_local_irq_enable();
}

-void arch_cpu_idle_prepare(void)
-{
- local_fiq_enable();
-}
-
void arch_cpu_idle_enter(void)
{
ledtrig_cpu(CPU_LED_IDLE_START);
--
2.25.1

2022-12-30 09:49:46

by Yajun Deng

Subject: Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare()

December 1, 2022 11:13 AM, "Yajun Deng" <[email protected]> wrote:

> arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
> just a wrapper for local_fiq_enable().
>
> The local_fiq_enable() was already called before cpu_startup_entry().
>
> So remove redundant arch_cpu_idle_prepare().
>
> Signed-off-by: Yajun Deng <[email protected]>
> ---
> arch/arm/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f811733a8fc5..e3f490ab95f4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -81,11 +81,6 @@ void arch_cpu_idle(void)
> raw_local_irq_enable();
> }
>
> -void arch_cpu_idle_prepare(void)
> -{
> - local_fiq_enable();
> -}
> -
> void arch_cpu_idle_enter(void)
> {
> ledtrig_cpu(CPU_LED_IDLE_START);
> --
> 2.25.1

Ping.