2022-12-01 01:40:44

by zhang.songyi

Subject: [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon

From: zhang songyi <[email protected]>

The semicolon after the "}" is unneeded.

Signed-off-by: zhang songyi <[email protected]>
---
drivers/mmc/host/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 42aaeabcad22..8413180a1039 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
case MMC_TIMING_UHS_DDR50:
case MMC_TIMING_MMC_DDR52:
return true;
- };
+ }
return false;
}

--
2.15.2

2022-12-01 11:03:04

by Ulf Hansson

Subject: Re: [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon

On Thu, 1 Dec 2022 at 02:26, <[email protected]> wrote:
>
> From: zhang songyi <[email protected]>
>
> The semicolon after the "}" is unneeded.
>
> Signed-off-by: zhang songyi <[email protected]>

Please run checkpatch (./scripts/checkpatch.pl) to make sure there are
no obvious formatting problems with your patch. This time it gives the
below warning, please fix it and resubmit a new version.

WARNING: please, no spaces at the start of a line
#79: FILE: drivers/mmc/host/sdhci.c:2292:
+ }$

total: 0 errors, 1 warnings, 8 lines checked

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 42aaeabcad22..8413180a1039 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
> case MMC_TIMING_UHS_DDR50:
> case MMC_TIMING_MMC_DDR52:
> return true;
> - };
> + }
> return false;
> }
>
> --
> 2.15.2