2022-12-01 13:01:54

by Yunfei Dong (董云飞)

[permalink] [raw]
Subject: [PATCH v3,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

From: Yunfei Dong <[email protected]>

mt8195 and mt8192 have different clock numbers, can't write 'clocks' and
'clock-names' with const value.

Signed-off-by: Yunfei Dong <[email protected]>
---
Reference series:
[1]: v5 of this series is presend by Allen-KH Cheng.
message-id: [email protected]
---
.../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
index 7c5b4a91c59b..09781ef02193 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
@@ -110,15 +110,12 @@ patternProperties:
Refer to bindings/iommu/mediatek,iommu.yaml.

clocks:
+ minItems: 1
maxItems: 5

clock-names:
- items:
- - const: sel
- - const: soc-vdec
- - const: soc-lat
- - const: vdec
- - const: top
+ minItems: 1
+ maxItems: 5

assigned-clocks:
maxItems: 1
--
2.18.0


2022-12-02 00:45:43

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

On Thu, Dec 01, 2022 at 08:15:22PM +0800, Yunfei Dong wrote:
> From: Yunfei Dong <[email protected]>
>
> mt8195 and mt8192 have different clock numbers, can't write 'clocks' and
> 'clock-names' with const value.
>
> Signed-off-by: Yunfei Dong <[email protected]>
> ---
> Reference series:
> [1]: v5 of this series is presend by Allen-KH Cheng.
> message-id: [email protected]
> ---
> .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index 7c5b4a91c59b..09781ef02193 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> @@ -110,15 +110,12 @@ patternProperties:
> Refer to bindings/iommu/mediatek,iommu.yaml.
>
> clocks:
> + minItems: 1
> maxItems: 5
>
> clock-names:
> - items:
> - - const: sel
> - - const: soc-vdec
> - - const: soc-lat
> - - const: vdec
> - - const: top
> + minItems: 1
> + maxItems: 5

Names need to be defined. This is a step backwards.

Rob

>
> assigned-clocks:
> maxItems: 1
> --
> 2.18.0
>
>

Subject: Re: [PATCH v3,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

Il 02/12/22 00:57, Rob Herring ha scritto:
> On Thu, Dec 01, 2022 at 08:15:22PM +0800, Yunfei Dong wrote:
>> From: Yunfei Dong <[email protected]>
>>
>> mt8195 and mt8192 have different clock numbers, can't write 'clocks' and
>> 'clock-names' with const value.
>>
>> Signed-off-by: Yunfei Dong <[email protected]>
>> ---
>> Reference series:
>> [1]: v5 of this series is presend by Allen-KH Cheng.
>> message-id: [email protected]
>> ---
>> .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
>> index 7c5b4a91c59b..09781ef02193 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
>> @@ -110,15 +110,12 @@ patternProperties:
>> Refer to bindings/iommu/mediatek,iommu.yaml.
>>
>> clocks:
>> + minItems: 1
>> maxItems: 5
>>
>> clock-names:
>> - items:
>> - - const: sel
>> - - const: soc-vdec
>> - - const: soc-lat
>> - - const: vdec
>> - - const: top
>> + minItems: 1
>> + maxItems: 5
>
> Names need to be defined. This is a step backwards.
>

I was thinking the same but wanted to wait for someone else's opinion before.

Yunfei, this would be...

- if:
properties:
compatible:
.... mt8192
then:
clock-names:
.... whatever we have

- if:
properties... blah mt8195
then:
clock-names:
..... new ones

...you should know already, but I'm just trying to speed up things here.

Cheers,
Angelo

> Rob
>
>>
>> assigned-clocks:
>> maxItems: 1
>> --
>> 2.18.0
>>
>>


2022-12-03 03:30:49

by Yunfei Dong (董云飞)

[permalink] [raw]
Subject: Re: [PATCH v3,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

Hi Angelo,

Thanks for your suggestion.

I already sent patch v4 before your suggestion. Looks the solution is
the same.

Could you please help to review patch v4 again when you are free?

Thanks.

Best Regards,
Yunfei Dong

On Fri, 2022-12-02 at 12:37 +0100, AngeloGioacchino Del Regno wrote:
> Il 02/12/22 00:57, Rob Herring ha scritto:
> > On Thu, Dec 01, 2022 at 08:15:22PM +0800, Yunfei Dong wrote:
> > > From: Yunfei Dong <[email protected]>
> > >
> > > mt8195 and mt8192 have different clock numbers, can't write
> > > 'clocks' and
> > > 'clock-names' with const value.
> > >
> > > Signed-off-by: Yunfei Dong <[email protected]>
> > > ---
> > > Reference series:
> > > [1]: v5 of this series is presend by Allen-KH Cheng.
> > > message-id:
> > > [email protected]
> > > ---
> > > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 9
> > > +++------
> > > 1 file changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > > decoder.yaml
> > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > > decoder.yaml
> > > index 7c5b4a91c59b..09781ef02193 100644
> > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > subdev-decoder.yaml
> > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > subdev-decoder.yaml
> > > @@ -110,15 +110,12 @@ patternProperties:
> > > Refer to bindings/iommu/mediatek,iommu.yaml.
> > >
> > > clocks:
> > > + minItems: 1
> > > maxItems: 5
> > >
> > > clock-names:
> > > - items:
> > > - - const: sel
> > > - - const: soc-vdec
> > > - - const: soc-lat
> > > - - const: vdec
> > > - - const: top
> > > + minItems: 1
> > > + maxItems: 5
> >
> > Names need to be defined. This is a step backwards.
> >
>
> I was thinking the same but wanted to wait for someone else's opinion
> before.
>
> Yunfei, this would be...
>
> - if:
> properties:
> compatible:
> .... mt8192
> then:
> clock-names:
> .... whatever we have
>
> - if:
> properties... blah mt8195
> then:
> clock-names:
> ..... new ones
>
> ...you should know already, but I'm just trying to speed up things
> here.
>
> Cheers,
> Angelo
>
> > Rob
> >
> > >
> > > assigned-clocks:
> > > maxItems: 1
> > > --
> > > 2.18.0
> > >
> > >
>
>