2022-12-02 15:04:11

by Michael Walle

Subject: [PATCH net-next] net: phy: mxl-gpy: rename MMD_VEND1 macros to match datasheet

Rename the temperature sensors macros to match the names in the
datasheet.

Signed-off-by: Michael Walle <[email protected]>
---
For the curious: I probably copied the prefix from the already existing
VPSPEC2_ macros in the driver, the datasheet also mentions some VPSPEC2_
names, but I suspect they are typos.

drivers/net/phy/mxl-gpy.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 27c0f161623e..0ff7ef076072 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -78,8 +78,8 @@
VSPEC1_SGMII_CTRL_ANRS)

/* Temperature sensor */
-#define VPSPEC1_TEMP_STA 0x0E
-#define VPSPEC1_TEMP_STA_DATA GENMASK(9, 0)
+#define VSPEC1_TEMP_STA 0x0E
+#define VSPEC1_TEMP_STA_DATA GENMASK(9, 0)

/* WoL */
#define VPSPEC2_WOL_CTL 0x0E06
@@ -140,14 +140,14 @@ static int gpy_hwmon_read(struct device *dev,
struct phy_device *phydev = dev_get_drvdata(dev);
int ret;

- ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, VPSPEC1_TEMP_STA);
+ ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, VSPEC1_TEMP_STA);
if (ret < 0)
return ret;
if (!ret)
return -ENODATA;

*value = polynomial_calc(&poly_N_to_temp,
- FIELD_GET(VPSPEC1_TEMP_STA_DATA, ret));
+ FIELD_GET(VSPEC1_TEMP_STA_DATA, ret));

return 0;
}
--
2.30.2

2022-12-02 18:25:13

by Andrew Lunn

Subject: Re: [PATCH net-next] net: phy: mxl-gpy: rename MMD_VEND1 macros to match datasheet

On Fri, Dec 02, 2022 at 03:49:00PM +0100, Michael Walle wrote:
> Rename the temperature sensors macros to match the names in the
> datasheet.
>
> Signed-off-by: Michael Walle <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2022-12-05 12:12:33

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: phy: mxl-gpy: rename MMD_VEND1 macros to match datasheet

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Fri, 2 Dec 2022 15:49:00 +0100 you wrote:
> Rename the temperature sensors macros to match the names in the
> datasheet.
>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> For the curious: I probably copied the prefix from the already existing
> VPSPEC2_ macros in the driver, the datasheet also mentions some VPSPEC2_
> names, but I suspect they are typos.
>
> [...]

Here is the summary with links:
- [net-next] net: phy: mxl-gpy: rename MMD_VEND1 macros to match datasheet
https://git.kernel.org/netdev/net-next/c/343a5d358e4a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html