2022-12-04 09:48:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/6] arm64: dts: qcom: sm8450: align MMC node names with dtschema

The bindings expect "mmc" for MMC/SDHCI nodes:

qcom/sm8450-sony-xperia-nagara-pdx223.dtb: sdhci@8804000: $nodename:0: 'sdhci@8804000' does not match '^mmc(@.*)?$'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index f20db5456765..e0d30dadbf8b 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3354,7 +3354,7 @@ ufs_mem_phy_lanes: phy@1d87400 {
};
};

- sdhc_2: sdhci@8804000 {
+ sdhc_2: mmc@8804000 {
compatible = "qcom,sm8450-sdhci", "qcom,sdhci-msm-v5";
reg = <0 0x08804000 0 0x1000>;

--
2.34.1


2022-12-04 10:07:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 4/6] arm64: dts: qcom: sda660-inforce-ifc6560: fix no-mmc property for SDHCI

There is no "no-emmc" property, so intention for SD/SDIO only nodes was
to use "no-mmc":

qcom/sda660-inforce-ifc6560.dtb: mmc@c084000: Unevaluated properties are not allowed ('no-emmc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
index cddbeade1ffc..7c81918eee66 100644
--- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
+++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
@@ -438,7 +438,7 @@ &sdhc_2 {

cd-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;
no-sdio;
- no-emmc;
+ no-mmc;
};

&tlmm {
--
2.34.1

2022-12-04 10:42:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/6] arm64: dts: qcom: sa8155p-adp: fix no-mmc property for SDHCI

There is no "no-emmc" property, so intention for SD/SDIO only nodes was
to use "no-mmc":

qcom/sa8155p-adp.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 01ac460d910e..25e2d9a2429e 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -397,7 +397,7 @@ &sdhc_2 {
vmmc-supply = <&vreg_l17a_2p96>; /* Card power line */
bus-width = <4>;
no-sdio;
- no-emmc;
+ no-mmc;
};

&uart2 {
--
2.34.1

2022-12-04 10:44:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 5/6] arm64: dts: qcom: sdm845-sony-xperia-tama: fix no-mmc property for SDHCI

There is no "no-emmc" property, so intention for SD/SDIO only nodes was
to use "no-mmc":

qcom/sdm845-sony-xperia-tama-akatsuki.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
index 51ee42e3c995..87dd0fc36747 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
@@ -376,7 +376,7 @@ &sdhc_2 {
pinctrl-names = "default";
bus-width = <4>;
no-sdio;
- no-emmc;
+ no-mmc;
};

&tlmm {
--
2.34.1

2022-12-04 10:58:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/6] arm64: dts: qcom: qrb5165-rb: fix no-mmc property for SDHCI

There is no "no-emmc" property, so intention for SD/SDIO only nodes was
to use "no-mmc":

qcom/qrb5165-rb5.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index 4c39cec0b13e..8c64cb060e21 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -904,7 +904,7 @@ &sdhc_2 {
cd-gpios = <&tlmm 77 GPIO_ACTIVE_LOW>;
bus-width = <4>;
no-sdio;
- no-emmc;
+ no-mmc;
};

&sound {
--
2.34.1

2022-12-04 11:13:43

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 3/6] arm64: dts: qcom: sa8155p-adp: fix no-mmc property for SDHCI

On Sun, 4 Dec 2022 at 11:44, Krzysztof Kozlowski
<[email protected]> wrote:
>
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sa8155p-adp.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-12-04 11:22:15

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sdm845-sony-xperia-tama: fix no-mmc property for SDHCI

On Sun, 4 Dec 2022 at 11:44, Krzysztof Kozlowski
<[email protected]> wrote:
>
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sdm845-sony-xperia-tama-akatsuki.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-12-04 11:22:28

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 2/6] arm64: dts: qcom: qrb5165-rb: fix no-mmc property for SDHCI

On Sun, 4 Dec 2022 at 11:44, Krzysztof Kozlowski
<[email protected]> wrote:
>
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/qrb5165-rb5.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-12-04 11:28:46

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8450: align MMC node names with dtschema

On Sun, 4 Dec 2022 at 11:44, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The bindings expect "mmc" for MMC/SDHCI nodes:
>
> qcom/sm8450-sony-xperia-nagara-pdx223.dtb: sdhci@8804000: $nodename:0: 'sdhci@8804000' does not match '^mmc(@.*)?$'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-12-04 11:37:27

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sda660-inforce-ifc6560: fix no-mmc property for SDHCI

On Sun, 4 Dec 2022 at 11:44, Krzysztof Kozlowski
<[email protected]> wrote:
>
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sda660-inforce-ifc6560.dtb: mmc@c084000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-12-05 11:26:17

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/6] arm64: dts: qcom: qrb5165-rb: fix no-mmc property for SDHCI



On 04/12/2022 10:44, Krzysztof Kozlowski wrote:
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/qrb5165-rb5.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 4c39cec0b13e..8c64cb060e21 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -904,7 +904,7 @@ &sdhc_2 {
> cd-gpios = <&tlmm 77 GPIO_ACTIVE_LOW>;
> bus-width = <4>;
> no-sdio;
> - no-emmc;
> + no-mmc;
> };
>
> &sound {

2022-12-05 11:28:12

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sdm845-sony-xperia-tama: fix no-mmc property for SDHCI



On 04/12/2022 10:44, Krzysztof Kozlowski wrote:
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sdm845-sony-xperia-tama-akatsuki.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> index 51ee42e3c995..87dd0fc36747 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> @@ -376,7 +376,7 @@ &sdhc_2 {
> pinctrl-names = "default";
> bus-width = <4>;
> no-sdio;
> - no-emmc;
> + no-mmc;
> };
>
> &tlmm {

2022-12-05 11:35:49

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sda660-inforce-ifc6560: fix no-mmc property for SDHCI



On 04/12/2022 10:44, Krzysztof Kozlowski wrote:
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sda660-inforce-ifc6560.dtb: mmc@c084000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> index cddbeade1ffc..7c81918eee66 100644
> --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> @@ -438,7 +438,7 @@ &sdhc_2 {
>
> cd-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;
> no-sdio;
> - no-emmc;
> + no-mmc;
> };
>
> &tlmm {

2022-12-05 11:38:06

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8450: align MMC node names with dtschema



On 04/12/2022 10:44, Krzysztof Kozlowski wrote:
> The bindings expect "mmc" for MMC/SDHCI nodes:
>
> qcom/sm8450-sony-xperia-nagara-pdx223.dtb: sdhci@8804000: $nodename:0: 'sdhci@8804000' does not match '^mmc(@.*)?$'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index f20db5456765..e0d30dadbf8b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3354,7 +3354,7 @@ ufs_mem_phy_lanes: phy@1d87400 {
> };
> };
>
> - sdhc_2: sdhci@8804000 {
> + sdhc_2: mmc@8804000 {
> compatible = "qcom,sm8450-sdhci", "qcom,sdhci-msm-v5";
> reg = <0 0x08804000 0 0x1000>;
>

2022-12-05 11:39:02

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 3/6] arm64: dts: qcom: sa8155p-adp: fix no-mmc property for SDHCI



On 04/12/2022 10:44, Krzysztof Kozlowski wrote:
> There is no "no-emmc" property, so intention for SD/SDIO only nodes was
> to use "no-mmc":
>
> qcom/sa8155p-adp.dtb: mmc@8804000: Unevaluated properties are not allowed ('no-emmc' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 01ac460d910e..25e2d9a2429e 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -397,7 +397,7 @@ &sdhc_2 {
> vmmc-supply = <&vreg_l17a_2p96>; /* Card power line */
> bus-width = <4>;
> no-sdio;
> - no-emmc;
> + no-mmc;
> };
>
> &uart2 {

2022-12-06 18:38:02

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/6] arm64: dts: qcom: sm8450: align MMC node names with dtschema

On Sun, 4 Dec 2022 10:44:33 +0100, Krzysztof Kozlowski wrote:
> The bindings expect "mmc" for MMC/SDHCI nodes:
>
> qcom/sm8450-sony-xperia-nagara-pdx223.dtb: sdhci@8804000: $nodename:0: 'sdhci@8804000' does not match '^mmc(@.*)?$'
>
>

Applied, thanks!

[1/6] arm64: dts: qcom: sm8450: align MMC node names with dtschema
commit: 4b660ee5d0e9b9c8c61ceea285fd437bc0f3c673
[2/6] arm64: dts: qcom: qrb5165-rb: fix no-mmc property for SDHCI
commit: 1821f483f666049eacc5812c5cae36c29659c1ad
[3/6] arm64: dts: qcom: sa8155p-adp: fix no-mmc property for SDHCI
commit: f50f5a817777185c7d0bbc03e2dafbde25e98428
[4/6] arm64: dts: qcom: sda660-inforce-ifc6560: fix no-mmc property for SDHCI
commit: 6e36e6c6b3d15442b0fed406f2449f00e0a01c1a
[5/6] arm64: dts: qcom: sdm845-sony-xperia-tama: fix no-mmc property for SDHCI
commit: 796d8eaa165a8573dcc0a966c7845c67f7918e27
[6/6] arm64: dts: qcom: sm8250-sony-xperia-edo: fix no-mmc property for SDHCI
commit: afa8e18bf674f00c8c3a73e295ff2f6aacdad82a

Best regards,
--
Bjorn Andersson <[email protected]>