2022-12-01 04:37:44

by ye.xingchen

Subject: [PATCH] iio: common: scmi_iio: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Replace the open-code with sysfs_emit() to simplify the code.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/iio/common/scmi_sensors/scmi_iio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
index d92f7f651f7b..0c2caf3570db 100644
--- a/drivers/iio/common/scmi_sensors/scmi_iio.c
+++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
@@ -400,12 +400,12 @@ static ssize_t scmi_iio_get_raw_available(struct iio_dev *iio_dev,
rem = do_div(resolution,
int_pow(10, abs(exponent))
);
- len = scnprintf(buf, PAGE_SIZE,
+ len = sysfs_emit(buf,
"[%lld %llu.%llu %lld]\n", min_range,
resolution, rem, max_range);
} else {
resolution = resolution * int_pow(10, exponent);
- len = scnprintf(buf, PAGE_SIZE, "[%lld %llu %lld]\n",
+ len = sysfs_emit(buf, "[%lld %llu %lld]\n",
min_range, resolution, max_range);
}
}
--
2.25.1

2022-12-04 15:55:29

by Jonathan Cameron

Subject: Re: [PATCH] iio: common: scmi_iio: use sysfs_emit() to instead of scnprintf()

On Thu, 1 Dec 2022 11:56:31 +0800 (CST)
<[email protected]> wrote:

> From: ye xingchen <[email protected]>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <[email protected]>
Applied. Cc'd scmi people as well just in case they are interested.


> ---
> drivers/iio/common/scmi_sensors/scmi_iio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
> index d92f7f651f7b..0c2caf3570db 100644
> --- a/drivers/iio/common/scmi_sensors/scmi_iio.c
> +++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
> @@ -400,12 +400,12 @@ static ssize_t scmi_iio_get_raw_available(struct iio_dev *iio_dev,
> rem = do_div(resolution,
> int_pow(10, abs(exponent))
> );
> - len = scnprintf(buf, PAGE_SIZE,
> + len = sysfs_emit(buf,
> "[%lld %llu.%llu %lld]\n", min_range,
> resolution, rem, max_range);
> } else {
> resolution = resolution * int_pow(10, exponent);
> - len = scnprintf(buf, PAGE_SIZE, "[%lld %llu %lld]\n",
> + len = sysfs_emit(buf, "[%lld %llu %lld]\n",
> min_range, resolution, max_range);
> }
> }

2022-12-05 10:57:54

by Sudeep Holla

Subject: Re: [PATCH] iio: common: scmi_iio: use sysfs_emit() to instead of scnprintf()

On Sun, Dec 04, 2022 at 03:49:06PM +0000, Jonathan Cameron wrote:
> On Thu, 1 Dec 2022 11:56:31 +0800 (CST)
> <[email protected]> wrote:
>
> > From: ye xingchen <[email protected]>
> >
> > Replace the open-code with sysfs_emit() to simplify the code.
> >
> > Signed-off-by: ye xingchen <[email protected]>
> Applied. Cc'd scmi people as well just in case they are interested.

Thanks Ye for the patch and Jonathan for Cc-in and applying.

--
Regards,
Sudeep