2022-12-06 10:17:07

by Denis Arefev

[permalink] [raw]
Subject: [PATCH] file: Added pointer check

Return value of a function 'affs_bread' is dereferenced at file.c:970
without checking for null, but it is usually checked for this function.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Denis Arefev <[email protected]>
---
fs/affs/file.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/affs/file.c b/fs/affs/file.c
index d91b0133d95d..4566fa767f65 100644
--- a/fs/affs/file.c
+++ b/fs/affs/file.c
@@ -963,6 +963,8 @@ affs_truncate(struct inode *inode)

while (ext_key) {
ext_bh = affs_bread(sb, ext_key);
+ if (!ext_bh)
+ break;
size = AFFS_SB(sb)->s_hashsize;
if (size > blkcnt - blk)
size = blkcnt - blk;
--
2.25.1