2022-12-07 12:20:31

by Miaoqian Lin

Subject: [PATCH] device property: Fix documentation for fwnode_get_next_parent()

Use fwnode_handle_put() on the node pointer to release the refcount.
Change fwnode_handle_node() to fwnode_handle_put().

Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/base/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index 2a5a37fcd998..daa1e379762b 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
* node's parents.
*
* Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
*/
struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
{
--
2.25.1

2022-12-07 12:21:42

by Andy Shevchenko

Subject: Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()

On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> Use fwnode_handle_put() on the node pointer to release the refcount.
> Change fwnode_handle_node() to fwnode_handle_put().

Looks correct to me, thanks!
Reviewed-by: Andy Shevchenko <[email protected]>

> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/base/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 2a5a37fcd998..daa1e379762b 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> * node's parents.
> *
> * Returns a node pointer with refcount incremented, use
> - * fwnode_handle_node() on it when done.
> + * fwnode_handle_put() on it when done.
> */
> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> {
> --
> 2.25.1
>

--
With Best Regards,
Andy Shevchenko

2022-12-07 12:51:53

by Sakari Ailus

Subject: Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()

On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> Use fwnode_handle_put() on the node pointer to release the refcount.
> Change fwnode_handle_node() to fwnode_handle_put().
>
> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> Signed-off-by: Miaoqian Lin <[email protected]>

Thanks!

Acked-by: Sakari Ailus <[email protected]>

> ---
> drivers/base/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 2a5a37fcd998..daa1e379762b 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> * node's parents.
> *
> * Returns a node pointer with refcount incremented, use
> - * fwnode_handle_node() on it when done.
> + * fwnode_handle_put() on it when done.
> */
> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> {

--
Kind regards,

Sakari Ailus

2022-12-07 15:29:33

by Rafael J. Wysocki

Subject: Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()

On Wed, Dec 7, 2022 at 1:21 PM Sakari Ailus
<[email protected]> wrote:
>
> On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> > Use fwnode_handle_put() on the node pointer to release the refcount.
> > Change fwnode_handle_node() to fwnode_handle_put().
> >
> > Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> > Signed-off-by: Miaoqian Lin <[email protected]>
>
> Thanks!
>
> Acked-by: Sakari Ailus <[email protected]>

So I'm assuming that Greg will pick up this one or please let me know otherwise.

> > ---
> > drivers/base/property.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 2a5a37fcd998..daa1e379762b 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> > * node's parents.
> > *
> > * Returns a node pointer with refcount incremented, use
> > - * fwnode_handle_node() on it when done.
> > + * fwnode_handle_put() on it when done.
> > */
> > struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> > {
>
> --

2022-12-07 16:26:02

by Greg KH

Subject: Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()

On Wed, Dec 07, 2022 at 03:30:43PM +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 7, 2022 at 1:21 PM Sakari Ailus
> <[email protected]> wrote:
> >
> > On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> > > Use fwnode_handle_put() on the node pointer to release the refcount.
> > > Change fwnode_handle_node() to fwnode_handle_put().
> > >
> > > Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> > > Signed-off-by: Miaoqian Lin <[email protected]>
> >
> > Thanks!
> >
> > Acked-by: Sakari Ailus <[email protected]>
>
> So I'm assuming that Greg will pick up this one or please let me know otherwise.

I'll grab it now, thanks.

greg k-h