2022-12-09 00:04:46

by Stuart Hayes

Subject: [PATCH] acpi: add support for the NBFT

Add support for the NVMe Boot Firmware Table (NBFT) to facilitate
booting from NVM Express namespaces which are accessed via
NVMe over Fabrics (NVMe-oF).

Signed-off-by: Stuart Hayes <[email protected]>
Signed-off-by: Doug Farley <[email protected]>
Signed-off-by: Lenny Szubowicz <[email protected]>
---
drivers/acpi/tables.c | 3 ++-
include/acpi/actbl1.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 47ec11d4c68e..f390c5883b56 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
- ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
+ ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
+ ACPI_SIG_NBFT };

#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index 15c78678c5d3..6ec43410288a 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -49,6 +49,8 @@
#define ACPI_SIG_S3PT "S3PT" /* S3 Performance (sub)Table */
#define ACPI_SIG_PCCS "PCC" /* PCC Shared Memory Region */

+#define ACPI_SIG_NBFT "NBFT" /* NVMe Boot Firmware Table */
+
/* Reserved table signatures */

#define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */
--
2.31.1

2022-12-14 18:29:13

by John Meneghini

Subject: Re: [PATCH] acpi: add support for the NBFT

Reviewed-by: John Meneghini <[email protected]>

On 12/8/22 18:25, Stuart Hayes wrote:
> Add support for the NVMe Boot Firmware Table (NBFT) to facilitate
> booting from NVM Express namespaces which are accessed via
> NVMe over Fabrics (NVMe-oF).
>
> Signed-off-by: Stuart Hayes <[email protected]>
> Signed-off-by: Doug Farley <[email protected]>
> Signed-off-by: Lenny Szubowicz <[email protected]>
> ---
> drivers/acpi/tables.c | 3 ++-
> include/acpi/actbl1.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 47ec11d4c68e..f390c5883b56 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
> + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
> + ACPI_SIG_NBFT };
>
> #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 15c78678c5d3..6ec43410288a 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -49,6 +49,8 @@
> #define ACPI_SIG_S3PT "S3PT" /* S3 Performance (sub)Table */
> #define ACPI_SIG_PCCS "PCC" /* PCC Shared Memory Region */
>
> +#define ACPI_SIG_NBFT "NBFT" /* NVMe Boot Firmware Table */
> +
> /* Reserved table signatures */
>
> #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */

2022-12-30 18:07:49

by Rafael J. Wysocki

Subject: Re: [PATCH] acpi: add support for the NBFT

On Fri, Dec 9, 2022 at 12:25 AM Stuart Hayes <[email protected]> wrote:
>
> Add support for the NVMe Boot Firmware Table (NBFT) to facilitate
> booting from NVM Express namespaces which are accessed via
> NVMe over Fabrics (NVMe-oF).
>
> Signed-off-by: Stuart Hayes <[email protected]>

Tentatively applied as 6.3 material, but it was unclear what the S-o-b
tags below mean, so I've dropped them.

If you are not the original author of the patch, you should add a From
line pointing to the original author to it and the corresponding S-o-b
tag along with your S-o-b.

If you have developed the patch in collaboration with someone, there
should be a Co-developed-by tag pointing to the other author along
with the corresponding S-o-b tag.

S-o-b alone is meaningful only if you are sending a patch from someone
else, for example as a code maintainer.

> Signed-off-by: Doug Farley <[email protected]>
> Signed-off-by: Lenny Szubowicz <[email protected]>
> ---
> drivers/acpi/tables.c | 3 ++-
> include/acpi/actbl1.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 47ec11d4c68e..f390c5883b56 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
> + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
> + ACPI_SIG_NBFT };
>
> #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 15c78678c5d3..6ec43410288a 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -49,6 +49,8 @@
> #define ACPI_SIG_S3PT "S3PT" /* S3 Performance (sub)Table */
> #define ACPI_SIG_PCCS "PCC" /* PCC Shared Memory Region */
>
> +#define ACPI_SIG_NBFT "NBFT" /* NVMe Boot Firmware Table */
> +
> /* Reserved table signatures */
>
> #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */
> --
> 2.31.1
>

2023-01-12 19:56:36

by John Meneghini

Subject: Re: [PATCH] acpi: add support for the NBFT

Thank Rafael.

To clarify: this patch was developed by Stuart Hayes. So there should be no need for that additional Signed-off-bys.

Sorry for the confusion...

John A. Meneghini
Senior Principal Platform Storage Engineer
RHEL SST - Platform Storage Group
[email protected]

On 12/30/22 12:45, Rafael J. Wysocki wrote:
> On Fri, Dec 9, 2022 at 12:25 AM Stuart Hayes <[email protected]> wrote:
>>
>> Add support for the NVMe Boot Firmware Table (NBFT) to facilitate
>> booting from NVM Express namespaces which are accessed via
>> NVMe over Fabrics (NVMe-oF).
>>
>> Signed-off-by: Stuart Hayes <[email protected]>
>
> Tentatively applied as 6.3 material, but it was unclear what the S-o-b
> tags below mean, so I've dropped them.
>
> If you are not the original author of the patch, you should add a From
> line pointing to the original author to it and the corresponding S-o-b
> tag along with your S-o-b.
>
> If you have developed the patch in collaboration with someone, there
> should be a Co-developed-by tag pointing to the other author along
> with the corresponding S-o-b tag.
>
> S-o-b alone is meaningful only if you are sending a patch from someone
> else, for example as a code maintainer.
>
>> Signed-off-by: Doug Farley <[email protected]>
>> Signed-off-by: Lenny Szubowicz <[email protected]>
>> ---
>> drivers/acpi/tables.c | 3 ++-
>> include/acpi/actbl1.h | 2 ++
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
>> index 47ec11d4c68e..f390c5883b56 100644
>> --- a/drivers/acpi/tables.c
>> +++ b/drivers/acpi/tables.c
>> @@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
>> ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
>> ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
>> ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
>> - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
>> + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
>> + ACPI_SIG_NBFT };
>>
>> #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>>
>> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
>> index 15c78678c5d3..6ec43410288a 100644
>> --- a/include/acpi/actbl1.h
>> +++ b/include/acpi/actbl1.h
>> @@ -49,6 +49,8 @@
>> #define ACPI_SIG_S3PT "S3PT" /* S3 Performance (sub)Table */
>> #define ACPI_SIG_PCCS "PCC" /* PCC Shared Memory Region */
>>
>> +#define ACPI_SIG_NBFT "NBFT" /* NVMe Boot Firmware Table */
>> +
>> /* Reserved table signatures */
>>
>> #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */
>> --
>> 2.31.1
>>
>