2022-12-09 02:20:55

by Jeremy Kerr

[permalink] [raw]
Subject: [RFC PATCH v2 0/3] Add reset control for mfd syscon devices

This RFC series adds a facility for syscon devices to control a reset
line when probed; we have instances of simple register-only syscon
resources that need deassertion of a reset line for the register set to
be accessible.

Rather than requiring a specific driver to implement this, it'd be nice
to use the generic syscon device and the generic resets linkage to do
so.

Any comments/queries/etc are most welcome.

Cheers,


Jeremy
---
v2:
* do reset control in the early of_syscon_register() path, rather than
the platform device init, which isn't used.
* consequently, add regmap infrastructure to attach a reset
controller, in a similar way to attaching clocks

Jeremy Kerr (3):
dt-bindings: mfd/syscon: Add resets property
regmap: mmio: allow reset control in a MMIO regmap
mfd: syscon: allow reset control for syscon devices

.../devicetree/bindings/mfd/syscon.yaml | 3 +++
drivers/base/regmap/regmap-mmio.c | 22 +++++++++++++++
drivers/mfd/syscon.c | 27 ++++++++++++++-----
include/linux/regmap.h | 3 +++
4 files changed, 49 insertions(+), 6 deletions(-)

--
2.35.1


2022-12-09 12:01:15

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [RFC PATCH v2 0/3] Add reset control for mfd syscon devices

On Fri, Dec 9, 2022, at 02:33, Jeremy Kerr wrote:
> This RFC series adds a facility for syscon devices to control a reset
> line when probed; we have instances of simple register-only syscon
> resources that need deassertion of a reset line for the register set to
> be accessible.
>
> Rather than requiring a specific driver to implement this, it'd be nice
> to use the generic syscon device and the generic resets linkage to do
> so.
>
> Any comments/queries/etc are most welcome.

The syscon side looks good to me,

Reviewed-by: Arnd Bergmann <[email protected]>