2022-12-09 05:33:15

by Jiapeng Chong

Subject: [PATCH] mmc: sdhci-of-esdhc: Modify mismatched function name

No functional modification involved.

drivers/mmc/host/sdhci-of-esdhc.c:243: warning: expecting prototype for _fixup(). Prototype was for esdhc_writel_fixup() instead.
drivers/mmc/host/sdhci-of-esdhc.c:117: warning: expecting prototype for _fixup(). Prototype was for esdhc_readl_fixup() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3397
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index 9d875bb531a8..4712adac7f7c 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -98,7 +98,7 @@ struct sdhci_esdhc {
};

/**
- * esdhc_read*_fixup - Fixup the value read from incompatible eSDHC register
+ * esdhc_readl_fixup - Fixup the value read from incompatible eSDHC register
* to make it compatible with SD spec.
*
* @host: pointer to sdhci_host
@@ -223,7 +223,7 @@ static u8 esdhc_readb_fixup(struct sdhci_host *host,
}

/**
- * esdhc_write*_fixup - Fixup the SD spec register value so that it could be
+ * esdhc_writel_fixup - Fixup the SD spec register value so that it could be
* written into eSDHC register.
*
* @host: pointer to sdhci_host
--
2.20.1.7.g153144c

2022-12-09 07:54:31

by Adrian Hunter

Subject: Re: [PATCH] mmc: sdhci-of-esdhc: Modify mismatched function name

On 9/12/22 05:41, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/mmc/host/sdhci-of-esdhc.c:243: warning: expecting prototype for _fixup(). Prototype was for esdhc_writel_fixup() instead.
> drivers/mmc/host/sdhci-of-esdhc.c:117: warning: expecting prototype for _fixup(). Prototype was for esdhc_readl_fixup() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3397
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 9d875bb531a8..4712adac7f7c 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -98,7 +98,7 @@ struct sdhci_esdhc {
> };
>
> /**
> - * esdhc_read*_fixup - Fixup the value read from incompatible eSDHC register
> + * esdhc_readl_fixup - Fixup the value read from incompatible eSDHC register
> * to make it compatible with SD spec.
> *
> * @host: pointer to sdhci_host
> @@ -223,7 +223,7 @@ static u8 esdhc_readb_fixup(struct sdhci_host *host,
> }
>
> /**
> - * esdhc_write*_fixup - Fixup the SD spec register value so that it could be
> + * esdhc_writel_fixup - Fixup the SD spec register value so that it could be
> * written into eSDHC register.
> *
> * @host: pointer to sdhci_host

2022-12-09 09:57:58

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdhci-of-esdhc: Modify mismatched function name

On Fri, 9 Dec 2022 at 04:41, Jiapeng Chong
<[email protected]> wrote:
>
> No functional modification involved.
>
> drivers/mmc/host/sdhci-of-esdhc.c:243: warning: expecting prototype for _fixup(). Prototype was for esdhc_writel_fixup() instead.
> drivers/mmc/host/sdhci-of-esdhc.c:117: warning: expecting prototype for _fixup(). Prototype was for esdhc_readl_fixup() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3397
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 9d875bb531a8..4712adac7f7c 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -98,7 +98,7 @@ struct sdhci_esdhc {
> };
>
> /**
> - * esdhc_read*_fixup - Fixup the value read from incompatible eSDHC register
> + * esdhc_readl_fixup - Fixup the value read from incompatible eSDHC register
> * to make it compatible with SD spec.
> *
> * @host: pointer to sdhci_host
> @@ -223,7 +223,7 @@ static u8 esdhc_readb_fixup(struct sdhci_host *host,
> }
>
> /**
> - * esdhc_write*_fixup - Fixup the SD spec register value so that it could be
> + * esdhc_writel_fixup - Fixup the SD spec register value so that it could be
> * written into eSDHC register.
> *
> * @host: pointer to sdhci_host
> --
> 2.20.1.7.g153144c
>