2022-12-10 03:51:39

by Colin Foster

Subject: [PATCH v5 net-next 05/10] dt-bindings: net: dsa: allow additional ethernet-port properties

Explicitly allow additional properties for both the ethernet-port and
ethernet-ports properties. This specifically will allow the qca8k.yaml
binding to use shared properties.

Signed-off-by: Colin Foster <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---

v4 -> v5
* Add Rob Reviewed

v3 -> v4
* Change ethernet-ports node to have "unevaluatedProperties: false"
instead of "additionalProperties: true"
* Change ethernet-port node to have "additionalProperties: true" instead
of "unevaluatedProperties: true"
* Add Reviewed tag

v2 -> v3
* No change

v1 -> v2
* New patch

---
Documentation/devicetree/bindings/net/dsa/dsa.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index 9375cdcfbf96..98a79be3bffe 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -41,6 +41,8 @@ patternProperties:
'#size-cells':
const: 0

+ unevaluatedProperties: false
+
patternProperties:
"^(ethernet-)?port@[0-9]+$":
type: object
@@ -48,7 +50,7 @@ patternProperties:

$ref: dsa-port.yaml#

- unevaluatedProperties: false
+ additionalProperties: true

oneOf:
- required:
--
2.25.1

2022-12-12 19:07:18

by Vladimir Oltean

Subject: Re: [PATCH v5 net-next 05/10] dt-bindings: net: dsa: allow additional ethernet-port properties

On Fri, Dec 09, 2022 at 07:30:28PM -0800, Colin Foster wrote:
> Explicitly allow additional properties for both the ethernet-port and
> ethernet-ports properties. This specifically will allow the qca8k.yaml
> binding to use shared properties.
>
> Signed-off-by: Colin Foster <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>